From bb38f0fcce73904e68d4cde8f9d85e9da2e93013 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 23 May 2016 07:19:45 +0000 Subject: http: chunk in the server, not middleware Since PSGI does not require Transfer-Encoding: chunked or Content-Length, we cannot expect random apps we host to chunk their responses. Thus, to improve interoperability, chunk at the HTTP layer like other PSGI servers do. I'm chosing a more syscall-intensive method (via multiple send(...MSG_MORE) for now to reduce copy + packet overhead. --- examples/public-inbox.psgi | 5 ----- 1 file changed, 5 deletions(-) (limited to 'examples') diff --git a/examples/public-inbox.psgi b/examples/public-inbox.psgi index 876fc762..4edbf5e3 100644 --- a/examples/public-inbox.psgi +++ b/examples/public-inbox.psgi @@ -12,11 +12,6 @@ PublicInbox::WWW->preload; use Plack::Builder; my $www = PublicInbox::WWW->new; builder { - # Chunked middleware conflicts with Starman: - # https://github.com/miyagawa/Starman/issues/23 - # However, it is strongly recommended to enable it if using - # public-inbox-httpd to allow persistent connections - # enable 'Chunked'; eval { enable 'Deflater', content_type => [ qw( -- cgit v1.2.3-24-ge0c7