From 8e0e850859fc9572cf201111728eaa621eace451 Mon Sep 17 00:00:00 2001 From: "Eric W. Biederman" Date: Mon, 30 Jul 2018 00:04:45 -0500 Subject: ProcessPipe.pm: Use read not sysread While playing with git fast export I discovered that mixing <> and read would give inconsistent results. I tracked the issue down to using sysread in ProcessPipe instead of plain read. If it is desirable to use readline I can't see how using sysread can work as readline to be efficient needs to use buffered I/O. Signed-off-by: "Eric W. Biederman" --- lib/PublicInbox/ProcessPipe.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/ProcessPipe.pm b/lib/PublicInbox/ProcessPipe.pm index 7bb6ddee..2769e064 100644 --- a/lib/PublicInbox/ProcessPipe.pm +++ b/lib/PublicInbox/ProcessPipe.pm @@ -11,7 +11,7 @@ sub TIEHANDLE { bless { pid => $pid, fh => $fh }, $class; } -sub READ { sysread($_[0]->{fh}, $_[1], $_[2], $_[3] || 0) } +sub READ { read($_[0]->{fh}, $_[1], $_[2], $_[3] || 0) } sub READLINE { readline($_[0]->{fh}) } -- cgit v1.2.3-24-ge0c7