From 1ab8dabe04ebba61fd8761dca3d569947cbe20be Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 9 Feb 2017 00:26:52 +0000 Subject: repobrowse: avoid slurping lines "foreach (<$fh>)" in Perl requests lines in array context, so use "while" instead for lazy reading. This follows ba4c50c20b95679580beba1ef290a4281d5285b7 in master ("config: do not slurp lines into memory") --- lib/PublicInbox/RepobrowseBase.pm | 2 +- lib/PublicInbox/RepobrowseGitSummary.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/RepobrowseBase.pm b/lib/PublicInbox/RepobrowseBase.pm index caec5ced..44f422df 100644 --- a/lib/PublicInbox/RepobrowseBase.pm +++ b/lib/PublicInbox/RepobrowseBase.pm @@ -24,7 +24,7 @@ sub mime_load { my ($self, $file) = @_; my %rv; open my $fh, '<', $file or return \%rv; - foreach (<$fh>) { + while (<$fh>) { next if /^#/; # no comments my ($type, @ext) = split(/\s+/); diff --git a/lib/PublicInbox/RepobrowseGitSummary.pm b/lib/PublicInbox/RepobrowseGitSummary.pm index b6b96028..e7739ecd 100644 --- a/lib/PublicInbox/RepobrowseGitSummary.pm +++ b/lib/PublicInbox/RepobrowseGitSummary.pm @@ -48,7 +48,7 @@ sub for_each_ref { ''); my $rel = $req->{relcmd}; - foreach (<$refs>) { + while (<$refs>) { my ($ref, $type, $hex, $date, $s) = split(' ', $_, 5); my $x = $ref eq $head_ref ? ' (HEAD)' : ''; $ref =~ s!\Arefs/(?:heads|tags)/!!; -- cgit v1.2.3-24-ge0c7