about summary refs log tree commit homepage
path: root/lib/PublicInbox/RepoBase.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2017-03-03 22:07:19 +0000
committerEric Wong <e@80x24.org>2017-03-03 22:12:19 +0000
commitb2492cc6ef642640c901ccca5ff96b9228cd10ec (patch)
tree4b9d730886d9a638388cf43ab1b8a7ff74bb4c33 /lib/PublicInbox/RepoBase.pm
parent3fb3433282f2c805878d5e6f02e2b04534cd5906 (diff)
downloadpublic-inbox-b2492cc6ef642640c901ccca5ff96b9228cd10ec.tar.gz
Implying a tip would make for ambiguous URLs and ruin
caching, so try to get everybody to hit the same URL.
This also simplifies some of our other code since
the tip is always in the request.
Diffstat (limited to 'lib/PublicInbox/RepoBase.pm')
-rw-r--r--lib/PublicInbox/RepoBase.pm4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/RepoBase.pm b/lib/PublicInbox/RepoBase.pm
index e600b1df..5d38579c 100644
--- a/lib/PublicInbox/RepoBase.pm
+++ b/lib/PublicInbox/RepoBase.pm
@@ -86,7 +86,7 @@ sub r {
                 my $env = $req->{env};
                 my $base = PublicInbox::Repobrowse::base_url($env);
                 my ($redir) = @extra;
-                if ($redir =~ m!\A\.\./!) { # relative redirect
+                if (index($redir, '/') != 0) { # relative redirect
                         my @orig = split(m!/+!, $env->{PATH_INFO});
                         my @dest = split(m!/+!, $redir);
 
@@ -98,7 +98,7 @@ sub r {
                         $end = pop @dest if $dest[-1] =~ /\A[#\?]/;
                         $redir = $base . join('/', @orig, @dest) . $end;
                 } else {
-                        $redir = $base . '/' . $redir;
+                        $redir = $base . $redir;
                 }
                 push @h, qw(Content-Type text/plain Location), $redir;