about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2017-02-14 22:45:15 +0000
committerEric Wong <e@80x24.org>2017-02-14 22:46:28 +0000
commit364de65f8a6b5729027cb70228312a141430122f (patch)
tree6405cfc19d403c72459fe542cbd34dff9d2be9a0
parentcb8fc8c39d0a820b35ed3384c35122aaa66f9a6f (diff)
downloadpublic-inbox-364de65f8a6b5729027cb70228312a141430122f.tar.gz
PSGI specs already require PATH_INFO to be unescaped;
so our tests were wrong, too.
-rw-r--r--lib/PublicInbox/WWW.pm2
-rw-r--r--t/cgi.t2
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index 430e6b19..62e4ca43 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -165,7 +165,7 @@ sub invalid_inbox_mid {
         my $ret = invalid_inbox($ctx, $inbox);
         return $ret if $ret;
 
-        $ctx->{mid} = $mid = uri_unescape($mid);
+        $ctx->{mid} = $mid;
         if ($mid =~ /\A[a-f0-9]{40}\z/) {
                 # this is horiffically wasteful for legacy URLs:
                 if ($mid = mid2blob($ctx)) {
diff --git a/t/cgi.t b/t/cgi.t
index 092ad8c7..77409660 100644
--- a/t/cgi.t
+++ b/t/cgi.t
@@ -148,7 +148,7 @@ EOF
         $im->add($reply);
         $im->done;
 
-        my $res = cgi_run("/test/slashy%2fasdf\@example.com/raw");
+        my $res = cgi_run("/test/slashy/asdf\@example.com/raw");
         like($res->{body}, qr/Message-Id: <\Q$slashy_mid\E>/,
                 "slashy mid raw hit");