From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [SQUASH] [PATCH 1/9] ds: improve DS->Reset fork-safety
Date: Wed, 24 Mar 2021 23:01:03 +0000 [thread overview]
Message-ID: <YFvEr7POlhYTOSkB@dcvr> (raw)
In-Reply-To: <20210324092335.12345-2-e@80x24.org>
Will squash the following in, no reason to have it accessible
via `our' unless we need to debug something. And I initally
considered calling it '%state' and stuffing all vars in there,
but decided just on-stack vars would be sufficient.
diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm
index c881c895..3cddfd18 100644
--- a/lib/PublicInbox/DS.pm
+++ b/lib/PublicInbox/DS.pm
@@ -35,7 +35,7 @@ use Errno qw(EAGAIN EINVAL);
use Carp qw(carp croak);
our @EXPORT_OK = qw(now msg_more dwaitpid add_timer);
-our %Stack;
+my %Stack;
my $nextq; # queue for next_tick
my $wait_pids; # list of [ pid, callback, callback_arg ]
my $later_q; # list of callbacks to run at some later interval
@@ -66,7 +66,6 @@ Reset();
Reset all state
=cut
-our %state;
sub Reset {
do {
$in_loop = undef; # first in case DESTROY callbacks use this
next prev parent reply other threads:[~2021-03-24 23:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 9:23 [PATCH 0/9] lei: various corner case leak fixes Eric Wong
2021-03-24 9:23 ` [PATCH 1/9] ds: improve DS->Reset fork-safety Eric Wong
2021-03-24 23:01 ` Eric Wong [this message]
2021-03-24 9:23 ` [PATCH 2/9] mbox_lock: dotlock: chdir for relative lock paths Eric Wong
2021-03-24 9:23 ` [PATCH 3/9] lei: drop circular reference in lei_store process Eric Wong
2021-03-24 9:23 ` [PATCH 4/9] lei: update {3} after -C chdirs Eric Wong
2021-03-24 9:23 ` [PATCH 5/9] lei: clean up pkt_op consumer on exception, too Eric Wong
2021-03-24 9:23 ` [PATCH 6/9] lei_store: give process a better name Eric Wong
2021-03-24 9:23 ` [PATCH 7/9] v2writable: cleanup SQLite handles on --xapian-only Eric Wong
2021-03-24 9:23 ` [PATCH 8/9] lei_mirror: fix circular reference Eric Wong
2021-03-24 9:23 ` [PATCH 9/9] lei-daemon: do not leak FDs on bogus requests Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFvEr7POlhYTOSkB@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).