From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F258F1F55B for ; Fri, 5 Jun 2020 22:48:17 +0000 (UTC) Received: by mail-oo1-xc43.google.com with SMTP id i9so2321315ool.5 for ; Fri, 05 Jun 2020 15:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KVB+J2pAQHe8wMeP55cs9lumxSqDctkPz2494+HdAIo=; b=TIfZ4RIH9Bp7C+zhBSZyp4P70SIiWdJVhaMpuuF3Ku6qT40TTzd8a8W7W8AHl3VDoT 2UGjICtPbW2iiHJuJmXaeSZBfA0A14MW3MA9qaO/Pgr6ptBaOJkp1wFjzVrFGimiqwcL 85c12RBuFvT9wt7ET4uJuSnLhH0peZiBGs9/vSJxIdW1C9kcd0sxQXwob+L07BqIpGB0 Z0xxujjVWD4jfY0iemkFpOYuUPlyqUoBfj7PYk/xiyU1Phf6fQswF755Rlw+3Bd+sEzi N/RMGdp60ib563gQRcjZpNXPXtxgIW/qKFvacK6/+/6OODfkipYkKOx2ackorzNcht3k SlWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KVB+J2pAQHe8wMeP55cs9lumxSqDctkPz2494+HdAIo=; b=G07TEsYAxlGODe7QdeuJV3Fdjncs+J/nI1DTG6kkyzJ7YIO6wFWjBePXDjIbJrZspk nKlanYtn7ZlUUzRsA0Rwa+wQ1fZNwMaTc0R/oFkDVHfUIHzLU3J7gJ8qhpJ7aSB7Xh7I x0+aqqlgXcHWb5IScjiJbMmznReTECYT/8oyXRBLGKiZNuWgzifHXyQuK2x05iXWV81K 18umJRPOlFdNK9qxzASjTQ3nbaY0YXRqXpf3KdeR7YaHx5hlrH3S8zIoR/EBnrxkjoRQ NRKTy8+mZpKA/UNKOrD2Th14P55vi44NY5+YYyUOEFnWQPFn/XD8Dn+sB5i7xKtbOHt2 5gOQ== X-Gm-Message-State: AOAM532Dt2ayc5j1AVa5UdodY4+sa5ER1Lp93LiYOpvV8QrlTPBE9RRs 80WagkZ2/frhoXzhoEDkACH3HObtJbDgH3xXMf5z6a5I6KOzHA== X-Google-Smtp-Source: ABdhPJyW069/LXWIgfbz05JKGVRlcEi1SmgnhjGphq5D7DZId2Nzo6lmWpA0oaV+3tQVHnYjKPzcc4D7nkLZK8C8Bmg= X-Received: by 2002:a4a:94d1:: with SMTP id l17mr9438542ooi.88.1591397296670; Fri, 05 Jun 2020 15:48:16 -0700 (PDT) MIME-Version: 1.0 References: <20200605220321.GA17860@dcvr> In-Reply-To: <20200605220321.GA17860@dcvr> From: Varun Varada Date: Fri, 5 Jun 2020 17:48:05 -0500 Message-ID: Subject: Re: [Patch] Update 24-hour times to use two digits for the hour To: Eric Wong Cc: meta@public-inbox.org Content-Type: text/plain; charset="UTF-8" List-Id: Hi Eric, The "why?" is that leading zeroes are standard for virtually any 24-hour clock in the world (https://www.google.com/search?q=24-hour+time). This is even codified in the ISO 8601 standard (https://en.wikipedia.org/wiki/ISO_8601#Times), which the project seems to be following. Without a leading zero, a user immediately expects an a.m./p.m. modifier, which there is not. Varun Varun On Fri, 5 Jun 2020 at 17:03, Eric Wong wrote: > > Varun Varada wrote: > > Hello, > > > > Here is a patch to update the timestamps displayed to have 2 digits > > for the hour when since it is using the 24-hour clock: > > Hello Varun, thanks for your interest in the project. > > But why this patch? > > It's a requirement to document the "why?" for submitting any > patch to any project. > > > # human-friendly format > > -sub fmt_ts ($) { strftime('%Y-%m-%d %k:%M', gmtime($_[0])) } > > +sub fmt_ts ($) { strftime('%Y-%m-%d %H:%M', gmtime($_[0])) } > > As a human with degraded eyesight, I see leading zeros from > %H as visual noise which makes numbers harder to read. > > %k uses a leading space instead of zero, but still uses two > digits for >=10 hours. Pretty much any digital clock or timer > in the real world behaves the same way.