From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS11403 66.111.4.0/24 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D17271F463 for ; Tue, 24 Sep 2019 01:11:27 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B85C8215B2; Mon, 23 Sep 2019 21:11:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 23 Sep 2019 21:11:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=Hb5rpg8mqEn8tGAkBduz1rZjXO nPQl8P8V/vDcjihYI=; b=YsgCVjJ14Dqy1YyjekX0Q88s4rYpkyHXxFDoAd/Bne Ex0+o2fqhSZ2ymExN7Vfblm77gXmVBfFNi3/y2KJzj/IvwMdOGLWEaykdORDnv3j ck07KF57pPtUoUi/tQmwc2FZGywU2ewq/yla7Utms16IU37+YonmtJoiLcSPXrrR bb6HusWMZEc0SqNOP/UkYWUU7TudWazAXGwhGpbSkgp1XUhm/58PFmYtzxwF5bbG p2QmKK8btEKg4WWfLHV6D7K06ty7PXyYaED6SVFw4BF/a6Fyi+VIgp7YXrbzRhlT jlC7UPlWMVzzx2M2NObp+Pxr/j9YW75cRyiSJLaQMLNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Hb5rpg 8mqEn8tGAkBduz1rZjXOnPQl8P8V/vDcjihYI=; b=lEUd3s6sugX0ik7oQmw277 DK7adLn7EbA1merbor13J7D6FmJJoKdMaWHmCPP5FNjqDJkxuKDfn5KDzZdOlxrk Pczgoakz5CBZ9XmZcBbzfL8ZcYEFzxid7dPk+z+0GroM7nGkCykZ4Tmac93tdGp0 te1vQ7I5sKy1zAiBgfTCIKz/Mstl3UMa0rLn12FnDkyz1wdveII9g/E2rPbjqY9O TILI8HrviBleiiVCwFck79V6ABg5RMpE2gS7qbeEBfevmry8bKCLfCDCuU2sQwh4 wfcYeUnmtAXM5LH5/tRQmwdF0mT6r1nLQ2KN+T34YWv8GyRmpS3saCHrZBZDFQYw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdelgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhffkfggtgesghdtreertd dttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehhihesrghlhihsshgrrdhisheq necukfhppeekuddrudekjedrvddvgedrudeftdenucfrrghrrghmpehmrghilhhfrhhomh ephhhisegrlhihshhsrgdrihhsnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (130.224.187.81.in-addr.arpa [81.187.224.130]) by mail.messagingengine.com (Postfix) with ESMTPA id 0EA2ED6005A; Mon, 23 Sep 2019 21:11:25 -0400 (EDT) From: Alyssa Ross To: Eric Wong Cc: meta@public-inbox.org Subject: Re: [PATCH] t/spawn: fix with unusual env locations In-Reply-To: <20190915185519.GA4891@dcvr> References: <20190915134819.1406-1-hi@alyssa.is> <20190915185519.GA4891@dcvr> Date: Tue, 24 Sep 2019 01:11:18 +0000 Message-ID: <87zhiu4hxl.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: --=-=-= Content-Type: text/plain >> The call to spawn clears the environment, including PATH. This means >> that an env in a non-default location wouldn't be found, while all the >> other tests work because they use PATH. We can fix this by looking up >> which PATH to use beforehand. > > Thanks for reporting this issue, but... is that it? > We also use spawn() for 'git', among other things... Yes, I can confirm that this was the only failing test case in my build. (It may be of note however that I did not have Xapian enabled. Trying to build with that caused a host of other failures that were beyond my ability to troubleshoot, so I decided to just give up on running the tests for now, since they seem very dependent on the environment and the environment inside our build sandboxes is so different from what public-inbox will have on a running system anyway.) > For the pure Perl codepath, this ought to be a more encompassing > alternative to your patch: > > [ ... snip ... ] > > Can you confirm? Thanks. I can confirm that this patch also solves my problem. Thank you very much. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAl2JbTYACgkQ+dvtSFmy ccDA2Q//emVDEp2btI+KDOfakcxyuoX22RK/Eg11qGY2Ih1BvrdgGahr43oWwPK7 akwu783w7bjIvQ2+nIxwyplxOnu5zoq5c6/7Vsab/IHLRntX7g0aFB0IT1ADkIta Ca2PGw74sHSjkMCidm1Pdv0sEqQVbpod76QyYImshMUn2pWdvis7+Yy6fzghx0xE ABSn3+IV6L+aHiDRd+gZvBfBrmsrpioeb9OHM5bNnlhYQwEZk3coNXjVikpNniZL 1gkHsJkwo481djzY4gnnP+21ixDLueEyoo3meP4Uio0MpWn7Bgq6Bt6stnEgkyIH XJHbRF0SQcXYklTwbCB0andBp17qgXjh+IMHmJtX35t2GS9C8Gkm4Y051v75jawA KS0Buvt+O7uObOM3FYjY6TkiyPSS28vxn9GaYi2AV7eB7nHgVzmMdGLwza+trKXo /cP7x9JiBHGT2opOLI3dORjnv4VO0J9XBiSQWMjXCszlc0Hcsao7D8oyGafYEzzc b/FRFT4+YQwOg9kNtqn+sGfwXrJVLaOOwp0BW1ksbNr4AkwqT/IZywT1TQZ93KWP brD8zdSx/ETb8XGNv8LvyxXwa7UUsLybpUZqaO3tj094WZqwUOdauvYDVMtt4dlN 93AsPTqAMyuqmelO+XjKMIi9qnEoDMN578ddtQscMFRWpsG+VAM= =qxzT -----END PGP SIGNATURE----- --=-=-=--