user/dev discussion of public-inbox itself
 help / color / mirror / Atom feed
* [PATCH] scripts/dupe-finder: restore $dbh variable
@ 2020-10-16  2:08 Kyle Meyer
  2020-10-16  4:23 ` Eric Wong
  0 siblings, 1 reply; 3+ messages in thread
From: Kyle Meyer @ 2020-10-16  2:08 UTC (permalink / raw)
  To: meta

When dupe-finder was switched from ->search->{over_ro} to ->over, the
database handle was dropped.  Restore it because a spot downstream
uses it.

Fixes: 73e3a6ed6e95adc6 (use more idiomatic internal API for ->over access)
---
 scripts/dupe-finder | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/dupe-finder b/scripts/dupe-finder
index 7b490cbb..deeb0d6f 100644
--- a/scripts/dupe-finder
+++ b/scripts/dupe-finder
@@ -22,6 +22,7 @@ if (index($repo, '@') > 0) {
 $ibx or die "No inbox";
 $ibx->search or die "search not available for inbox";
 my $over = $ibx->over;
+my $dbh = $over->dbh;
 
 sub emit ($) {
 	my ($nums) = @_;

base-commit: 8080720d242f7450ecaf7e962c0f4ac9c5c2115b
-- 
2.28.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scripts/dupe-finder: restore $dbh variable
  2020-10-16  2:08 [PATCH] scripts/dupe-finder: restore $dbh variable Kyle Meyer
@ 2020-10-16  4:23 ` Eric Wong
  2020-10-16  5:02   ` Kyle Meyer
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Wong @ 2020-10-16  4:23 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: meta

Kyle Meyer <kyle@kyleam.com> wrote:
> When dupe-finder was switched from ->search->{over_ro} to ->over, the
> database handle was dropped.  Restore it because a spot downstream
> uses it.
> 
> Fixes: 73e3a6ed6e95adc6 (use more idiomatic internal API for ->over access)

Thanks, I haven't used this since 2018 :x

Btw, is this tool something you find useful?  I'll consider
making it part of a local tool I'm brainstorming...

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scripts/dupe-finder: restore $dbh variable
  2020-10-16  4:23 ` Eric Wong
@ 2020-10-16  5:02   ` Kyle Meyer
  0 siblings, 0 replies; 3+ messages in thread
From: Kyle Meyer @ 2020-10-16  5:02 UTC (permalink / raw)
  To: Eric Wong; +Cc: meta

Eric Wong writes:

> Btw, is this tool something you find useful?  I'll consider
> making it part of a local tool I'm brainstorming...

I found it very helpful when I made a mistake with a custom filter I use
to remove the footer at <https://yhetil.org/notmuch>.  The footer used
by the list changed at some point.  I updated the filter and restarted
-watch without thinking about what would happen with the messages that
were already in the maildir.  (I keep messages around for ~10 days
before deleting them.)  That led to a good number of duplicates.

Aside from that, I've run it a few times over the inboxes at
<https://yhetil.org>, and it's turned up a couple of hits.  So, I've
found it useful, but in the hosting context.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-16  5:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16  2:08 [PATCH] scripts/dupe-finder: restore $dbh variable Kyle Meyer
2020-10-16  4:23 ` Eric Wong
2020-10-16  5:02   ` Kyle Meyer

user/dev discussion of public-inbox itself

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ http://public-inbox.org/meta \
		meta@public-inbox.org
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git