user/dev discussion of public-inbox itself
 help / color / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Eric Wong <e@yhbt.net>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] wwwlisting: fix grep call for match=domain filtering
Date: Thu, 30 Jul 2020 10:58:38 -0400
Message-ID: <87tuxpkq1t.fsf@kyleam.com> (raw)
In-Reply-To: <20200730080353.GA14766@dcvr>

Eric Wong writes:

>>  sub list_match_domain_i {
>>  	my ($ibx, $arg) = @_;
>>  	my ($list, $hide_key, $re) = @$arg;
>> -	if (!$ibx->{-hide}->{$hide_key} && grep($re, @{$ibx->{url}})) {
>> +	if (!$ibx->{-hide}->{$hide_key} && grep(/$re/, @{$ibx->{url}})) {
>
> Gah, I keep getting languages/behaviors confused :x
>
> Especially confusing since `$string =~ $re' is documented
> in perlop(1) as being equivalent to `$string =~ /$re/'

Ah, good to know you find that bit in the documentation confusing too.
It had me scratching my head when I was debugging this, but I wasn't
sure if I was just missing something that would be obvious to someone
who knows perl.

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30  5:30 Kyle Meyer
2020-07-30  8:03 ` Eric Wong
2020-07-30 14:58   ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuxpkq1t.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=e@yhbt.net \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git