user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Dave Taht <dave@taht.net>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] nntp: add Path: header for leafnode
Date: Thu, 13 Jun 2019 10:53:28 -0700	[thread overview]
Message-ID: <87h88tmkx3.fsf@taht.net> (raw)
In-Reply-To: <20190613065413.4705-1-e@80x24.org> (Eric Wong's message of "Thu, 13 Jun 2019 06:54:13 +0000")

Eric Wong <e@80x24.org> writes:

> Apparently leafnode just needs any junk in the Path: header.
> Lets not waste bandwidth and just use a single byte to keep
> leafnode happy.
>
> Cc: Dave Taht <dave@taht.net>

Thx! awesome!

> ---
>  lib/PublicInbox/NNTP.pm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
> index 85778c4..5615cd7 100644
> --- a/lib/PublicInbox/NNTP.pm
> +++ b/lib/PublicInbox/NNTP.pm
> @@ -435,6 +435,10 @@ sub xref ($$$$) {
>  sub set_nntp_headers ($$$$$) {
>  	my ($self, $hdr, $ng, $n, $mid) = @_;
>  
> +	# why? leafnode requires a Path: header for some inexplicable
> +	# reason.  We'll fake the shortest one possible.
> +	$hdr->header_set('Path', 'y');
> +
>  	# clobber some
>  	my $xref = xref($self, $ng, $n, $mid);
>  	$hdr->header_set('Xref', $xref);

      reply	other threads:[~2019-06-13 17:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13  6:54 [PATCH] nntp: add Path: header for leafnode Eric Wong
2019-06-13 17:53 ` Dave Taht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h88tmkx3.fsf@taht.net \
    --to=dave@taht.net \
    --cc=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).