From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS11403 66.111.4.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4FC2C1F4BE for ; Tue, 1 Oct 2019 17:47:32 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 151A220CB1; Tue, 1 Oct 2019 13:47:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 01 Oct 2019 13:47:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=Adskhs8Ls4or+qD38l/POheOQ+ NOC4Y7uVfpJvKPAzo=; b=nSK0kzSWhkZkObAYkWOJ3G14S8h1v6mif2fkyR/CbC k/b2X9XlHfLt6mQT+iZoHjfm5ccrCFnlLWc0kPfXGjVJ7nngUHcUk80P7KlvvcRK mvGRVXqO6//B8+7DAp/SYOqSCPKbWFRU+oUNLuHlyL0WtUvwafHfAi3R4zR9q+Uh K1/lxoIcAEgkxek5iTeAPRJhD1anuXXFTTI9MSEi6RbhSyHkONBRAxIwe+uMyPnw apsNAAEmy3nWTxvcYcP6rGR+az8DS8vvgbLUQqN0yclaLlVVzt124EfHkW6wJnj5 jJ7nsR5eWLMrodYBolDWoK/on+qFGnyIJ/L2qXq0QJPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Adskhs 8Ls4or+qD38l/POheOQ+NOC4Y7uVfpJvKPAzo=; b=BMpHsyM2RdUo6b4u+Ott/g yPSQkU1UqD0u+lX80OQccM5FBpZyYhiB+j1U6XYbDrQXpVtHXpp+gUerQYErHD8O aWQbwxJqhsLo0Ll9/qDkY+CMCkB6DFoCSgzQWvb7iRCcwvVxGwp26LuqjKhKOG/F ojpWHtM4kU3/im6mkfERP0m3v0g9rrQxNyj2Jk/FqRvHGWBKAW8FQxQJz3TtNBN+ RntuAdwg+AA0S18smkDPu+F+YcwJD22JrLqLdsaoXt3TuEH+MH7ASLxpvNhGebjy AJGseRbgXQIAaBtB4LsXAxTXYkiJnTkg4gTF7E+yeBthJWSUn7rA67isArzcuADg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrgeeggdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffffkgggtsehgtderre dttddtnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhisegrlhihshhsrgdrihhs qeenucfkphepkeegrddukeegrddvvdegrdduhedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehhihesrghlhihsshgrrdhishenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (p54b8e096.dip0.t-ipconnect.de [84.184.224.150]) by mail.messagingengine.com (Postfix) with ESMTPA id EA7C88005C; Tue, 1 Oct 2019 13:47:29 -0400 (EDT) From: Alyssa Ross To: Eric Wong Cc: meta@public-inbox.org Subject: Re: [PATCH] #!/usr/bin/perl -> #!/usr/bin/env perl In-Reply-To: <20190926024938.GA19132@dcvr> References: <20190924204312.7875-1-hi@alyssa.is> <20190926024938.GA19132@dcvr> Date: Tue, 01 Oct 2019 17:47:26 +0000 Message-ID: <87a7akcq8h.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: --=-=-= Content-Type: text/plain >> certs/create-certs.perl | 2 +- > > Documentation in corresponding t/*.t files could be better > about running that and instead recommend "$^X" Makes sense. This was the one that was giving me problems in the first place. >> t/hl_mod.t | 2 +- > > Oops, there probably shouldn't have a shebang there at all > since none of the other *.t files have it. I've also seen > "#!perl -w" (no '/' at all) in other projects, but I don't think > it's worth the effort unless some external tools/highlighters > work better with it. I expect "#!/usr/bin/perl -w" to be most > compatible with highlighters and stuff like file(1). #!perl has some nice characteristics -- it's understood by the interpreter for setting flags, and for -x, but at the same time it's clear that a file with #!perl is not supposed to be directly executed. Assuming you don't want to change to #!perl, do you want a patch to recommend running certs/create-certs.perl and remove the shebang from t/hl_mod.t? And should the executable bits still be set on the other files? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAl2TkS4ACgkQ+dvtSFmy ccBGChAApH3XiusVT9RnPG97uK2x+TvmjdNL3athjqpwd7VoFTyZzIfcFJgrK3Vj lAcwOBfNqAS4ZnLycz1ucUgB4B0Eiho74E88Nb7qTJ3f5sVYL9wVRLjrJXl/sQub t5nATL4pa+sguC02hQCYGD/fmQibHRGlyQvqDxgSrSUj8hAEuOucT5DgEZwLxxr0 9UeqHKrVAxKcMv+iaO4mMrom1S7fxwJHyki1GlpwITRDAGXAegZImNNp60BvYugR bDJ1qLm230mKjclVDOX8mKUI7FgiGMgxJi3ZsPnSe4kbO3syS6eGqvsSobbs/qjz gHSBzPiTblGtkD8kG0r9BcUiQCA2V96tX1HiGee4/J3sULqFwGnXU9v8BnGGPPhV YPbvjSiqWc2iODm9+F5l5jxmfnYZtKKJaBjnIyo7cl/ImG6UUMCTyvqNOCIslb7Z ZIoWxEkZ8FDKBVVoxZwYEHO0jcpDRheE0FibMoNykgYVxUCgOw3tTdzAUx0l9ZrY hwZtgbyEGf3XGinWoP0LLClRR86v5K4yLM+RPHYPuLOOig+Py5F1vmJuMtXlSE0A bBeDiQNt+qtq93DKXfov3fcfPMCkxrXidFDDIyV7ai3B1fFdHh75uxZg+UyH/IlB R0ptlmVq36KuHTdWyj8vAdz5NHrlKsQHVtk7v15Ze8K+rJpiyH4= =yxjm -----END PGP SIGNATURE----- --=-=-=--