user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Gaelan Steele <gbs@canishe.com>
Cc: meta@public-inbox.org
Subject: Re: [RFT] syscall: set default constants for Inline::C platforms
Date: Mon, 8 Apr 2024 20:11:28 +0000	[thread overview]
Message-ID: <20240408201128.M138670@dcvr> (raw)
In-Reply-To: <29B30321-3B59-4C16-9AFF-A1E12B702D02@canishe.com>

Gaelan Steele <gbs@canishe.com> wrote:
>
> > On Apr 8, 2024, at 10:48 AM, Eric Wong <e@80x24.org> wrote:
> >
> >> I’m not enough of a Perl person to fully untangle this. As
> >> best I can tell, the intent is that non-Linux/BSD OSes should
> >> still work with Inline::C, but this doesn’t work in practice
> >> due to a bug?
> >
> > Right.  Patch below should fix it, test feedback appreciated.
>
> From a quick test, it seems to work: public-inbox-httpd starts
> and is happy to serve up an archive.
>
> Thanks for the quick fix!

No problem, thanks for the report and test.

> Ah, that’s the wrong email address. (My fault! My mail client
> has an unfortunate default I haven’t figured out how to change,
> and I forgot to set it before sending this time.) Would it be
> possible to use this one (gbs@canishe.com <mailto:gbs@canishe.com>) instead?

Sure, pushed as commit 832556492d3b94f9cadf9a4d249b519f30bae64d
with updated commit message:

    syscall: set default constants for Inline::C platforms

    This fixes compile errors on platforms we can't explicitly
    support from pure Perl due to the lack of syscall stability
    guarantees by the OS developers.

    Reported-by: Gaelan Steele <gbs@canishe.com>
    Tested-by: Gaelan Steele <gbs@canishe.com>

  reply	other threads:[~2024-04-08 20:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 14:56 [PATCH 00/14] IT'S ALIVE! www loads cindex join data Eric Wong
2023-11-28 14:56 ` [PATCH 01/14] test_common: create_*: detect changes all parameters Eric Wong
2023-11-28 14:56 ` [PATCH 02/14] t/cindex*: require SCM_RIGHTS for these tests Eric Wong
2024-01-29 21:23   ` [PATCH 0/2] pure Perl sendmsg/recvmsg on *BSD Eric Wong
2024-01-29 21:23     ` [PATCH 1/2] syscall: update formatting to match our codebase Eric Wong
2024-01-29 21:23     ` [PATCH 2/2] syscall: use pure Perl sendmsg/recvmsg on *BSD Eric Wong
2024-04-06  0:43       ` Gaelan Steele
2024-04-08  9:48         ` [RFT] syscall: set default constants for Inline::C platforms Eric Wong
2024-04-08 12:12           ` Gaelan Steele
2024-04-08 20:11             ` Eric Wong [this message]
2023-11-28 14:56 ` [PATCH 03/14] codesearch: eliminate redundant substitutions Eric Wong
2023-11-28 14:56 ` [PATCH 04/14] solver: schedule cleanup after synchronous git->check Eric Wong
2023-11-28 14:56 ` [PATCH 05/14] xap_helper.h: move cindex endpoints to separate file Eric Wong
2023-11-28 14:56 ` [PATCH 06/14] xap_helper: implement mset endpoint for WWW, IMAP, etc Eric Wong
2023-11-28 14:56 ` [PATCH 07/14] hval: use File::Spec to make relative paths for href Eric Wong
2023-11-28 14:56 ` [PATCH 08/14] www: load and use cindex join data Eric Wong
2023-11-28 14:56 ` [PATCH 09/14] git: speed up ->git_path for non-worktrees Eric Wong
2023-11-28 14:56 ` [PATCH 10/14] cindex: require `-g GIT_DIR' or `-r PROJECT_ROOT' Eric Wong
2023-11-28 14:56 ` [PATCH 11/14] git: speed up Git->new by 5% or so Eric Wong
2023-11-28 14:56 ` [PATCH 12/14] admin: resolve_git_dir respects symlinks Eric Wong
2023-11-28 14:56 ` [PATCH 13/14] cindex: extra quit checks Eric Wong
2023-11-28 14:56 ` [PATCH 14/14] www: start working on a repo listing Eric Wong
2023-11-28 17:55 ` [PATCH 15/14] www: load cindex join data for ->ALL, too Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240408201128.M138670@dcvr \
    --to=e@80x24.org \
    --cc=gbs@canishe.com \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).