From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/2] viewvcs: HTML fixes for commits
Date: Mon, 12 Feb 2024 13:13:50 +0000 [thread overview]
Message-ID: <20240212131350.3443394-3-e@80x24.org> (raw)
In-Reply-To: <20240212131350.3443394-1-e@80x24.org>
The "patch is too large to show" text is now broken by an <hr>
to prevent it from being confused as part of a commit message
(or having somebody intentionally insert that text in a commit
message to confuse readers). A missing </pre> is also necessary
before the <hr> tag for the related commit search form.
---
lib/PublicInbox/ViewVCS.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 2a305303..61329db6 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -274,7 +274,7 @@ EOM
undef $bdy; # free memory
my $fh = delete $ctx->{patch_fh};
if (-s $fh > $MAX_SIZE) {
- print $zfh "---\n patch is too large to show\n";
+ print $zfh '</pre><hr><pre>patch is too large to show</pre>';
} else { # prepare flush_diff:
seek $fh, 0, SEEK_SET;
PublicInbox::IO::read_all $fh, -s _, \$x;
@@ -312,7 +312,7 @@ EOM
$alt = '';
}
print $zfh <<EOM;
-<hr><form action="$ibx_url"
+</pre><hr><form action="$ibx_url"
id=related><pre>find related emails, including ancestors/descendants/conflicts
<textarea name=q cols=${\PublicInbox::View::COLS} rows=$rows>$q</textarea>
<input type=submit value="search$alt"
prev parent reply other threads:[~2024-02-12 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 13:13 [PATCH 0/2] viewvcs improvements Eric Wong
2024-02-12 13:13 ` [PATCH 1/2] viewvcs: parallelize commit display Eric Wong
2024-02-12 19:58 ` Eric Wong
2024-02-12 13:13 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212131350.3443394-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).