user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: "Štěpán Němec" <stepnem@smrk.net>
Cc: meta@public-inbox.org
Subject: [PATCH v2] view: decode In-Reply-To comments added by some MUAs
Date: Fri, 9 Feb 2024 09:33:01 +0000	[thread overview]
Message-ID: <20240209093301.M112200@dcvr> (raw)
In-Reply-To: <20240208104513+0100.315029-stepnem@smrk.net>

Štěpán Němec <stepnem@smrk.net> wrote:
> Eric Wong wrote:
> > Subject: [PATCH] view: decode In-Reply-To comments added by Gnus

> Or just "some MUAs"?  Who knows who else...

Yeah, I wouldn't be surprised if there were more...

---8<---
Subject: [PATCH] view: decode In-Reply-To comments added by some MUAs

Emacs-based MUAs (e.g. Gnus and rmail) can do it, and maybe
some others, too.  I noticed it in
<https://yhbt.net/lore/git/xmqqr0ho9oi9.fsf@gitster.g/>
while scanning for something else.
---
 lib/PublicInbox/View.pm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 697535ff..44e1f2a8 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -744,7 +744,11 @@ href="d/">diff</a>)</pre><pre>];
 	}
 	my @irt = $eml->header_raw('In-Reply-To');
 	my $refs;
-	if (!@irt) {
+	if (@irt) { # ("so-and-so's message of $DATE") added by some MUAs
+		for (grep(/=\?/, @irt)) {
+			s/(=\?.*)\z/PublicInbox::Eml::mhdr_decode $1/se;
+		}
+	} else {
 		$refs = references($eml);
 		$irt[0] = pop(@$refs) if scalar @$refs;
 	}

      reply	other threads:[~2024-02-09  9:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08  0:04 [PATCH] view: decode In-Reply-To comments added by Gnus Eric Wong
2024-02-08  9:45 ` Štěpán Němec
2024-02-09  9:33   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240209093301.M112200@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --cc=stepnem@smrk.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).