From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D4A521F51A for ; Tue, 16 Jan 2024 11:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1705405975; bh=LHKHm2+2k9fHdKkS3hXgNPFyPTGClWl0zUTiqotZCEw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=NQO4WmDxJTyLK3+YuLX3rxcHQxfDiGSlUDftER0okIXQSNETUMDV2Y/fWLBh+P0R3 8eowDibyoPXZJ+CXqoc69rk0e+mYDnFpvlGthLoyABMdkOzQW5ylFNMgma+AB1Q3IQ HBDWarKAt7jw0dDeNAlX9M8Zyjxt6EFWPXqZoYB0= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/5] config: don't vivify invalid fields for coderepos Date: Tue, 16 Jan 2024 11:52:53 +0000 Message-ID: <20240116115255.3554317-4-e@80x24.org> In-Reply-To: <20240116115255.3554317-1-e@80x24.org> References: <20240116115255.3554317-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We don't need 404s for non-existent coderepos creating fake (and invalid) entries. I noticed this while working on subsequent changes to support globbing in URLs. --- lib/PublicInbox/Config.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm index 6bebf790..33c59ec7 100644 --- a/lib/PublicInbox/Config.pm +++ b/lib/PublicInbox/Config.pm @@ -699,8 +699,8 @@ sub get_coderepo { $self->{-coderepos}->{$nick} // do { defined($self->{-cgit_scan_path}) ? do { apply_cgit_scan_path($self); - $self->{-coderepos}->{$nick} = - fill_coderepo($self, $nick); + my $cr = fill_coderepo($self, $nick); + $cr ? ($self->{-coderepos}->{$nick} = $cr) : undef; } : undef; }; }