From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/4] xap_helper.h: fix non-assignable stderr case
Date: Fri, 1 Dec 2023 02:07:03 +0000 [thread overview]
Message-ID: <20231201020705.2752562-3-e@80x24.org> (raw)
In-Reply-To: <20231201020705.2752562-1-e@80x24.org>
I mixed up "flush" with "close" :x
Fixes: 87b7f633f241 (xap_helper: implement mset endpoint for WWW, IMAP, etc...)
---
lib/PublicInbox/xap_helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/xap_helper.h b/lib/PublicInbox/xap_helper.h
index 18665567..c1ab66f3 100644
--- a/lib/PublicInbox/xap_helper.h
+++ b/lib/PublicInbox/xap_helper.h
@@ -714,7 +714,7 @@ static void stderr_restore(FILE *tmp_err)
stderr = orig_err;
return;
#endif
- ERR_CLOSE(stderr, EXIT_FAILURE);
+ ERR_FLUSH(stderr);
while (dup2(orig_err_fd, STDERR_FILENO) < 0) {
if (errno != EINTR)
err(EXIT_FAILURE, "dup2(%d => 2)", orig_err_fd);
next prev parent reply other threads:[~2023-12-01 2:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 2:07 [PATCH 0/4] DragonFly-related fixes Eric Wong
2023-12-01 2:07 ` [PATCH 1/4] t/xap_helper: make sendmsg errors more obvious Eric Wong
2023-12-01 2:07 ` Eric Wong [this message]
2023-12-01 2:07 ` [PATCH 3/4] tests: note kevent+tmpfs failures on DragonFly <= 6.4 Eric Wong
2023-12-01 2:07 ` [PATCH 4/4] xap_helper: enable stderr assignment on DragonFly Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201020705.2752562-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).