user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] cindex: fix --join=reset and speed up incremental joins
Date: Fri, 24 Nov 2023 09:53:46 +0000	[thread overview]
Message-ID: <20231124095346.3935-1-e@80x24.org> (raw)

`reset' means we want to ignore existing join data, while
the default (non-reset) means we perform an incremental
join while taking into account existing (fuzzy) join data.
---
 lib/PublicInbox/CodeSearchIdx.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/CodeSearchIdx.pm b/lib/PublicInbox/CodeSearchIdx.pm
index 3a551c84..81ca5cbc 100644
--- a/lib/PublicInbox/CodeSearchIdx.pm
+++ b/lib/PublicInbox/CodeSearchIdx.pm
@@ -997,7 +997,7 @@ sub init_join_postfork ($) {
 	require_progs('join', join => \@JOIN);
 	my $d2 = '([0-9]{2})';
 	my $dt_re = qr!([0-9]{4})$d2$d2$d2$d2$d2!;
-	if (my $cur = $JOIN{reset} ? current_join_data($self) : undef) {
+	if (my $cur = $JOIN{reset} ? undef : current_join_data($self)) {
 		if (($cur->{dt}->[1] // '') =~ m!\A$dt_re\z!o) {
 			my ($Y, $m, $d, $H, $M, $S) = ($1, $2, $3, $4, $5, $6);
 			my $t = timegm($S, $M, $H, $d, $m - 1, $Y);

                 reply	other threads:[~2023-11-24  9:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231124095346.3935-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).