Re: [PATCH] public-inbox-mda: use <sysexits.h> status codes where applicable

[Eric Wong <e@80x24.org>]

Leah Neukirchen <leah@vuxu.org> wrote:
> Many MTA understand these and map them to sensible SMTP error messages.
> 
> Inability to find an inbox results in "5.1.1 user unknown".
> Misformatted messages are rejected with "5.6.0 data format error".
> Unsupported inbox versions are reported as "5.3.5 local configuration error".
> 
> All of these are interpreted as permanent failures.

Resurrecting an ancient topic...

> diff --git a/script/public-inbox-mda b/script/public-inbox-mda
> index 766d58a..1f1252a 100755
> --- a/script/public-inbox-mda
> +++ b/script/public-inbox-mda
> @@ -38,8 +38,8 @@ my $config = PublicInbox::Config->new;
>  my $recipient = $ENV{ORIGINAL_RECIPIENT};
>  defined $recipient or die "ORIGINAL_RECIPIENT not defined in ENV\n";

Btw, our current code still dies if ORIGINAL_RECIPIENT is unset
instead of using a sysexit.h code.

Should that be changed to EX_USAGE or EX_NOUSER instead of die?

Since we already use EX_NOUSER right below:

>  my $dst = $config->lookup($recipient); # first check
> -defined $dst or do_exit(1);
> -my $main_repo = $dst->{mainrepo} or do_exit(1);
> +defined $dst or do_exit(67); # EX_NOUSER 5.1.1 user unknown
> +my $main_repo = $dst->{mainrepo} or do_exit(67);

Just something I noticed this while making unrelated changes to -mda...