From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] lei_mirror: fix seek/sysseek argument ordering
Date: Sun, 29 Oct 2023 05:56:32 +0000 [thread overview]
Message-ID: <20231029055632.1538737-1-e@80x24.org> (raw)
It doesn't matter in practice for platforms we support, since
SEEK_SET is `0' everywhere I've seen.
---
lib/PublicInbox/LeiMirror.pm | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm
index c2f7cbed..0f378768 100644
--- a/lib/PublicInbox/LeiMirror.pm
+++ b/lib/PublicInbox/LeiMirror.pm
@@ -171,7 +171,7 @@ sub _get_txt_done { # returns true on error (non-fatal), undef on success
$? = 0; # don't influence normal lei exit
return warn("$uri missing\n") if ($cerr >> 8) == 22;
return warn("# @$cmd failed (non-fatal)\n") if $cerr;
- seek($fh, SEEK_SET, 0);
+ seek($fh, 0, SEEK_SET);
$self->{"mtime.$endpoint"} = (stat($fh))[9];
$self->{"txt.$endpoint"} = read_all($fh, -s _);
undef; # success
@@ -305,8 +305,8 @@ sub fgrp_update {
return if !keep_going($fgrp);
my $srcfh = delete $fgrp->{srcfh} or return;
my $dstfh = delete $fgrp->{dstfh} or return;
- seek($srcfh, SEEK_SET, 0);
- seek($dstfh, SEEK_SET, 0);
+ seek($srcfh, 0, SEEK_SET);
+ seek($dstfh, 0, SEEK_SET);
my %src = map { chomp; split(/\0/) } (<$srcfh>);
close $srcfh;
my %dst = map { chomp; split(/\0/) } (<$dstfh>);
@@ -512,7 +512,7 @@ EOM
my $f = "$o/info/alternates";
my $l = File::Spec->abs2rel($alt, File::Spec->rel2abs($o));
open my $fh, '+>>', $f;
- seek($fh, SEEK_SET, 0);
+ seek($fh, 0, SEEK_SET);
chomp(my @cur = <$fh>);
if (!grep(/\A\Q$l\E\z/, @cur)) {
say $fh $l;
@@ -532,7 +532,7 @@ sub fp_done {
}
return if !keep_going($self);
my $fh = delete $self->{-show_ref} // die 'BUG: no show-ref output';
- sysseek($fh, SEEK_SET, 0);
+ sysseek($fh, 0, SEEK_SET);
$self->{-ent} // die 'BUG: no -ent';
my $A = $self->{-ent}->{fingerprint} // die 'BUG: no fingerprint';
my $B = sha_all(1, $fh)->hexdigest;
@@ -729,7 +729,7 @@ sub up_fp_done {
my ($self) = @_;
return if !keep_going($self);
my $fh = delete $self->{-show_ref_up} // die 'BUG: no show-ref output';
- sysseek($fh, SEEK_SET, 0);
+ sysseek($fh, 0, SEEK_SET);
$self->{-ent} // die 'BUG: no -ent';
my $A = $self->{-ent}->{fingerprint} // die 'BUG: no fingerprint';
my $B = sha_all(1, $fh)->hexdigest;
@@ -1083,7 +1083,7 @@ sub dump_manifest ($$) {
# epoch they no longer want to skip
my $json = PublicInbox::Config->json->encode($m);
my $mtime = (stat($ft))[9];
- seek($ft, SEEK_SET, 0);
+ seek($ft, 0, SEEK_SET);
truncate($ft, 0);
gzip(\$json => $ft) or die "gzip($ft): $GzipError";
$ft->flush or die "flush($ft): $!";
reply other threads:[~2023-10-29 5:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231029055632.1538737-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).