From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/1] test_common: call DS->Reset instead of cleanup_task
Date: Thu, 14 Sep 2023 13:02:26 +0000 [thread overview]
Message-ID: <20230914130226.M433545@dcvr> (raw)
In-Reply-To: <20230914125056.1898553-1-e@80x24.org>
cleanup_task is long gone since all that cleanup work got moved
into DS itself. Forcing a Reset here may solve some cleanup
segfaults I've noticed on OpenBSD 7.3 (and no other OSes).
---
lib/PublicInbox/TestCommon.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index a8323e4d..a0c3d065 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -365,7 +365,7 @@ sub run_script ($;$$) {
chdir $d or die "chdir $d: $!";
}
_run_sub($sub, $key, \@argv);
- eval { PublicInbox::Inbox::cleanup_task() };
+ eval { PublicInbox::DS->Reset() };
die "fchdir(restore): $!" if $cwdfh && !chdir($cwdfh);
_undo_redirects($orig_io);
select STDOUT;
next prev parent reply other threads:[~2023-09-14 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 12:50 [PATCH] ds: Reset at END Eric Wong
2023-09-14 13:02 ` Eric Wong [this message]
2023-09-14 20:52 ` [PATCHv2 2/1] test_common: eliminate call to non-existent cleanup_task Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230914130226.M433545@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).