user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/5] test_common: lei_ok: improve diagnostics
Date: Sat,  3 Apr 2021 10:48:24 +0000	[thread overview]
Message-ID: <20210403104827.17003-3-e@80x24.org> (raw)
In-Reply-To: <20210403104827.17003-1-e@80x24.org>

$? is useful, as is labeling lei_err since I'm easily-confused :x
---
 lib/PublicInbox/TestCommon.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index d6e090dd..d506e4b5 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -494,7 +494,8 @@ sub lei_ok (@) {
 			s!\Q$PWD\E\b!\$PWD!g;
 		}
 	}
-	ok(lei(@_), "lei @msg". ($msg ? " ($$msg)" : '')) or diag $lei_err;
+	ok(lei(@_), "lei @msg". ($msg ? " ($$msg)" : '')) or
+		diag "\$?=$? err=$lei_err";
 }
 
 sub json_utf8 () {

  parent reply	other threads:[~2021-04-03 10:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-03 10:48 [PATCH 0/5] lei/store: fix epoch roll, better errors Eric Wong
2021-04-03 10:48 ` [PATCH 1/5] lei_store: update alternates on new epoch Eric Wong
2021-04-03 10:48 ` Eric Wong [this message]
2021-04-03 10:48 ` [PATCH 3/5] lei tag: note message mismatches on failure Eric Wong
2021-04-03 10:48 ` [PATCH 4/5] lei: improve handling of Message-ID-less draft messages Eric Wong
2021-04-03 10:48 ` [PATCH 5/5] lei/store: (more) synchronous non-fatal error output Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210403104827.17003-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).