From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2CA651F9F4 for ; Sat, 3 Apr 2021 02:24:28 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 5/6] net_reader: fix read-only "lei convert" auth failures Date: Sat, 3 Apr 2021 02:24:26 +0000 Message-Id: <20210403022427.2430-6-e@80x24.org> In-Reply-To: <20210403022427.2430-1-e@80x24.org> References: <20210403022427.2430-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: "convert" is actually a bit more complicated than "lei import" since it may need auth for either input or output. --- lib/PublicInbox/NetReader.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm index c269d841..821e5d7f 100644 --- a/lib/PublicInbox/NetReader.pm +++ b/lib/PublicInbox/NetReader.pm @@ -264,10 +264,11 @@ sub imap_common_init ($;$) { my $mics = {}; # schema://authority => IMAPClient obj for my $uri (@{$self->{imap_order}}) { my $sec = uri_section($uri); - $mics->{$sec} //= mic_for($self, "$sec/", $mic_args, $lei); + my $mic = $mics->{$sec} //= + mic_for($self, "$sec/", $mic_args, $lei) // + die "Unable to continue\n"; next unless $self->isa('PublicInbox::NetWriter'); my $dst = $uri->mailbox // next; - my $mic = $mics->{$sec} // die "Unable to continue\n"; next if $mic->exists($dst); # already exists $mic->create($dst) or die "CREATE $dst failed <$uri>: $@"; }