From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, BODY_8BITS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 6A3A21F9FC; Fri, 26 Mar 2021 21:35:17 +0000 (UTC) Date: Fri, 26 Mar 2021 21:35:17 +0000 From: Eric Wong To: =?utf-8?B?zqPPhM6xz43Pgc6/z4Igzp3PhM6tzr3PhM6/z4I=?= Cc: meta@public-inbox.org Subject: Re: [PATCH v1] git-send-email-reply: Append subject Message-ID: <20210326213517.GA5730@dcvr> References: <20210326163146.30830-1-133706+stdedos@users.noreply.github.com> <20210326193633.GA14586@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: Σταύρος Ντέντος wrote: > On Fri, 26 Mar 2021 at 21:36, Eric Wong wrote: > > Stavros Ntentos wrote: > > > Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com> > > > > Unlike the git.git project, we don't require Signed-off-by. > > Furthermore, publicizing "noreply" addresses doesn't seem > > worthwhile since they're not usable email addresses. > > Forces of habit: > * git.git requires it, and > * github masks the e-mail addresses (from weird groupies), and tracks > contributions. Fair enough, pushed as 90ca1ac28edb2e8a64c30bb4be723643c646df89 with t/reply.t adjustments: https://public-inbox.org/meta/90ca1ac28edb2e8a64c30bb4be723643c646df89/s/ Also, please don't send HTML email. It wastes storage, bandwidth, and CPU cycles (spam filtering) for everybody involved. > LGTM; I am anyway not accustomed to perl, and neither do I have a testing > server. > Hopefully, there is a staging environment (or an easy-to-docker-setup one?) > that this can be POCed. I try to stick to widely-packaged dependencies to avoid the need for things like Docker (which I've never used). It should be reasonably easy-to-install on most GNU/Linux and *BSD distros; do you use anything exotic that's not covered in INSTALL and HACKING? https://public-inbox.org/INSTALL https://public-inbox.org/HACKING > Changes are anyway small enough, so I considered it safe to do it so. Yes, already deployed to the server that runs public-inbox.org/meta (I do development on that server :x) Thanks.