* [PATCH] examples: cgit-commit-filter: drop <tt> HTML tag, use title=
@ 2021-03-19 4:18 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-03-19 4:18 UTC (permalink / raw)
To: meta
<tt> doesn't seem necessary and it's deprecated in HTML, nowadays.
In any case, dillo's CSS support seems to show it as fixed-width
even without <tt>. Use the title= attribute to highlight that
it goes to the mail thread, too.
In the future, we'll probably link to something like "lei p2q"
(patch-to-query) to include OIDs in the search.
---
examples/cgit-commit-filter.lua | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/examples/cgit-commit-filter.lua b/examples/cgit-commit-filter.lua
index 9614c944..9857b3c9 100644
--- a/examples/cgit-commit-filter.lua
+++ b/examples/cgit-commit-filter.lua
@@ -31,12 +31,13 @@ function filter_close()
if u == nil then
html(buffer)
else
- html('<a href="' .. u .. '?x=t&q=')
+ html("<a\ntitle='mail thread'\n")
+ html('href="' .. u .. '?x=t&q=')
s = string.gsub(buffer, '"', '""')
html_url_arg('"' .. s .. '"')
- html('"><tt>')
+ html('">')
html_txt(buffer)
- html('</tt></a>')
+ html('</a>')
end
else
-- pass the body-through as-is
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-19 4:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19 4:18 [PATCH] examples: cgit-commit-filter: drop <tt> HTML tag, use title= Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).