From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/3] lei-related test fixes
Date: Sun, 3 Jan 2021 09:48:39 +0000 [thread overview]
Message-ID: <20210103094842.22906-1-e@80x24.org> (raw)
Still chasing down a weird problem which causes t/lei.t and
t/lei-oneshot.t to fail on FreeBSD 11.4 with IO::FDPass under
high load. No syscall errors are reported, but it's like the
FDs aren't passed at all... Maybe it's fixed in 12.x
1/3 is to cut down on noise
2/3 is a no-brainer :x
3/3 was for me to play around with, but also avoids malloc and
a potential leak in IO::FDPass (upstream's been notified).
However, I'm considering just making our C code pass all
3 FDs with one syscall since it's possible.
In any case, the C parts of PublicInbox::Spawn should probably
renamed PublicInbox::C...
Eric Wong (3):
t/lei: use $lei->() callback wrapper
testcommon: prepare_redirects: fix error message
spawn: support send_fd+recv_fd w/o IO::FDPass
lib/PublicInbox/LEI.pm | 6 ++-
lib/PublicInbox/Spawn.pm | 78 ++++++++++++++++++++++++++++++--
lib/PublicInbox/TestCommon.pm | 4 +-
script/lei | 7 ++-
t/lei.t | 84 ++++++++++++++++-------------------
t/spawn.t | 18 ++++++++
6 files changed, 141 insertions(+), 56 deletions(-)
next reply other threads:[~2021-01-03 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 9:48 Eric Wong [this message]
2021-01-03 9:48 ` [PATCH 1/3] t/lei: use $lei->() callback wrapper Eric Wong
2021-01-03 9:48 ` [PATCH 2/3] testcommon: prepare_redirects: fix error message Eric Wong
2021-01-03 9:48 ` [PATCH 3/3] spawn: support send_fd+recv_fd w/o IO::FDPass Eric Wong
2021-01-03 11:24 ` [PATCH 0/2] fix race from stdout buffering in FD pass exit Eric Wong
2021-01-03 11:24 ` [PATCH 1/2] send and receive all 3 FDs at once Eric Wong
2021-01-03 11:24 ` [PATCH 2/2] lei: fix output race in client/daemon mode Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210103094842.22906-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).