From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: meta@public-inbox.org
Subject: Extra newline when retrieving messages
Date: Thu, 10 Dec 2020 15:21:45 -0500 [thread overview]
Message-ID: <20201210202145.7agtcmrtl5jec42d@chatter.i7.local> (raw)
Hello:
While investigating why some of the messages retrieved via
lore.kernel.org were failing DKIM checks, I realized that
public-inbox-httpd appends an extra newline to message bodies. This
newline isn't present in git backends, just in messages retrieved via
(at least) public-inbox-httpd.
E.g.:
$ git clone --mirror https://lore.kernel.org/linux-modules/git/0.git
$ cd 0.git
$ git show 8c61c2a9ec6c4737d2da7258a0ff565d87d83d0b:m > /tmp/1
$ curl -s https://lore.kernel.org/linux-modules/20201129164737.135866-1-yauheni.kaliuta@redhat.com/raw > /tmp/2
$ diff -u /tmp/1 /tmp/2
--- /tmp/1 2020-12-10 15:06:15.815341700 -0500
+++ /tmp/2 2020-12-10 15:06:20.647345538 -0500
@@ -1,3 +1,4 @@
+From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <linux-modules-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
aws-us-west-2-korg-lkml-1.web.codeaurora.org
@@ -56,6 +57,9 @@
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Precedence: bulk
List-ID: <linux-modules.vger.kernel.org>
+Archived-At: <https://lore.kernel.org/linux-modules/20201129164737.135866-1-yauheni.kaliuta@redhat.com/>
+List-Archive: <https://lore.kernel.org/linux-modules/>
+List-Post: <mailto:linux-modules@vger.kernel.org>
The function allocates array but on building it if get_string()
fails it returns the error leaving the array allocated. The caller
@@ -83,3 +87,4 @@
--
2.29.2
+
^^^
This extra newline seems to be present whether a message is retrieved
via /raw or via /t.mbox.gz. It's benign in almost all cases except when
the message is signed using DKIM's "simple" mode, in which case it
causes DKIM signature to no longer verify (as "simple" doesn't do any
whitespace normalization before hashing body contents).
This appears to be present in the public-inbox version running on
https://public-inbox.org as well.
Best regards,
-K
next reply other threads:[~2020-12-10 20:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 20:21 Konstantin Ryabitsev [this message]
2020-12-10 20:55 ` Extra newline when retrieving messages Eric Wong
2020-12-10 21:43 ` Konstantin Ryabitsev
2020-12-10 22:29 ` Konstantin Ryabitsev
2020-12-10 22:38 ` Eric Wong
2020-12-10 22:41 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210202145.7agtcmrtl5jec42d@chatter.i7.local \
--to=konstantin@linuxfoundation.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).