user/dev discussion of public-inbox itself
 help / color / mirror / Atom feed
* [PATCH] config: warn on multiple values for some fields
@ 2020-09-20  1:43 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-09-20  1:43 UTC (permalink / raw)
  To: meta

Our code doesn't support multi-values for these, and having
unexpected arrays leads to unexpected results (e.g. showing
stuff like "ARRAY(0xDEADBEEFADD12E55)" in user interfaces).  So
warn and only use the last value (matching git-config(1)
behavior without `--get-all').
---
 lib/PublicInbox/Config.pm | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index 8ccf337d..abc525db 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -364,13 +364,23 @@ sub _fill {
 	my ($self, $pfx) = @_;
 	my $ibx = {};
 
-	foreach my $k (qw(inboxdir filter newsgroup
-			watch httpbackendmax
-			replyto feedmax nntpserver
-			indexlevel indexsequentialshard)) {
+	for my $k (qw(watch nntpserver)) {
 		my $v = $self->{"$pfx.$k"};
 		$ibx->{$k} = $v if defined $v;
 	}
+	for my $k (qw(filter inboxdir newsgroup replyto httpbackendmax feedmax
+			indexlevel indexsequentialshard)) {
+		if (defined(my $v = $self->{"$pfx.$k"})) {
+			if (ref($v) eq 'ARRAY') {
+				warn <<EOF;
+W: $pfx.$k has multiple values, only using `$v->[-1]'
+EOF
+				$ibx->{$k} = $v->[-1];
+			} else {
+				$ibx->{$k} = $v;
+			}
+		}
+	}
 
 	# backwards compatibility:
 	$ibx->{inboxdir} //= $self->{"$pfx.mainrepo"};

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-09-20  1:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-20  1:43 [PATCH] config: warn on multiple values for some fields Eric Wong

user/dev discussion of public-inbox itself

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ http://public-inbox.org/meta \
		meta@public-inbox.org
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git