user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] wwwstream: show init + index instructions for -V1, too
Date: Thu, 10 Sep 2020 05:46:04 +0000	[thread overview]
Message-ID: <20200910054604.31820-1-e@80x24.org> (raw)

This should've always been there.  I'm not sure how widely
spread 1.0 and earlier releases were, but we'll keep documenting
the version requirement.
---
 lib/PublicInbox/WwwStream.pm | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index e27da8c2..f7e09c24 100644
--- a/lib/PublicInbox/WwwStream.pm
+++ b/lib/PublicInbox/WwwStream.pm
@@ -122,23 +122,18 @@ EOF
 		push @urls, $u =~ /\Ahttps?:/ ? qq(<a\nhref="$u">$u</a>) : $u;
 	}
 
-	$urls .= "\n" .  join("\n", map { "\tgit clone --mirror $_" } @urls);
-	if (defined $max) {
-		my $addrs = $ibx->{address};
-		$addrs = join(' ', @$addrs) if ref($addrs) eq 'ARRAY';
-		$urls .=  <<EOF
-
+	$urls .= "\n" . join('', map { "\tgit clone --mirror $_\n" } @urls);
+	my $addrs = $ibx->{address};
+	$addrs = join(' ', @$addrs) if ref($addrs) eq 'ARRAY';
+	my $v = defined $max ? '-V2' : '-V1';
+	$urls .= <<EOF;
 
 	# If you have public-inbox 1.1+ installed, you may
 	# initialize and index your mirror using the following commands:
-	public-inbox-init -V2 $ibx->{name} $dir/ $http \\
+	public-inbox-init $v $ibx->{name} $dir/ $http \\
 		$addrs
 	public-inbox-index $dir
 EOF
-	} else { # v1
-		$urls .= "\n";
-	}
-
 	my $cfg_link = ($ctx->{-upfx} // '').'_/text/config/raw';
 	$urls .= <<EOF;
 

                 reply	other threads:[~2020-09-10  5:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910054604.31820-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).