From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@yhbt.net>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no
	version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 576631F66E;
	Fri, 28 Aug 2020 22:18:03 +0000 (UTC)
Date: Fri, 28 Aug 2020 22:18:03 +0000
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: Re: [PATCH 3/3] tests: check-run: show skipped tests
Message-ID: <20200828221803.GA89978@dcvr>
References: <20200828101300.17939-1-e@yhbt.net>
 <20200828101300.17939-4-e@yhbt.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200828101300.17939-4-e@yhbt.net>
List-Id: <meta.public-inbox.org>

Eric Wong <e@yhbt.net> wrote:
> +				my %nr;
> +				$nr{$_}++ for @sk;
> +				for (@sk) {
> +					my $n = delete $nr{$_} or next;
> +					print OLDERR "$pfx$_ ($n)\n";
> +				}

That's longer than it needs to be, we can grep here, too.

diff --git a/t/run.perl b/t/run.perl
index e3e3e075..0ba5e044 100755
--- a/t/run.perl
+++ b/t/run.perl
@@ -80,11 +80,8 @@ sub test_status () {
 			my @sk = (<$fh> =~ m/^ok [0-9]+ (# skip [^\n]+)/mgs);
 			if (@sk) {
 				my %nr;
-				$nr{$_}++ for @sk;
-				for (@sk) {
-					my $n = delete $nr{$_} or next;
-					print OLDERR "$pfx$_ ($n)\n";
-				}
+				my @err = grep { !$nr{$_}++ } @sk;
+				print OLDERR "$pfx$_ ($nr{$_})\n" for @err;
 				$skip = ' # total skipped: '.scalar(@sk);
 			}
 		} else {