From: Eric Wong <e@yhbt.net> To: meta@public-inbox.org Subject: [PATCH 4/5] over*: use v5.10.1, drop warnings Date: Wed, 26 Aug 2020 08:17:41 +0000 Message-ID: <20200826081742.16642-5-e@yhbt.net> (raw) In-Reply-To: <20200826081742.16642-1-e@yhbt.net> v5.10.1 lets us use the lighter parent.pm instead of base.pm, and we'll rely on the shebang to enable warnings (or not). While we're in the area, drop a no-longer-necessary import for PublicInbox::Search, since OverIdx doesn't require search. --- lib/PublicInbox/Over.pm | 2 +- lib/PublicInbox/OverIdx.pm | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm index 6b7d5216..0957cbdd 100644 --- a/lib/PublicInbox/Over.pm +++ b/lib/PublicInbox/Over.pm @@ -6,7 +6,7 @@ # tweaked/updated over time and rebuilt. package PublicInbox::Over; use strict; -use warnings; +use v5.10.1; use DBI; use DBD::SQLite; use PublicInbox::Smsg; diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm index 512c5f46..67f8cf65 100644 --- a/lib/PublicInbox/OverIdx.pm +++ b/lib/PublicInbox/OverIdx.pm @@ -9,14 +9,13 @@ # are denoted by a negative NNTP article number. package PublicInbox::OverIdx; use strict; -use warnings; -use base qw(PublicInbox::Over); +use v5.10.1; +use parent qw(PublicInbox::Over); use IO::Handle; use DBI qw(:sql_types); # SQL_BLOB use PublicInbox::MID qw/id_compress mids_for_index references/; use PublicInbox::Smsg qw(subject_normalized); use Compress::Zlib qw(compress); -use PublicInbox::Search; use Carp qw(croak); sub dbh_new {
next prev parent reply other threads:[~2020-08-26 8:17 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-26 8:17 [PATCH 0/5] some minor SQLite-related cleanups Eric Wong 2020-08-26 8:17 ` [PATCH 1/5] over: rename ->connect method to ->dbh Eric Wong 2020-08-26 8:17 ` [PATCH 2/5] over: rename ->disconnect to ->dbh_close Eric Wong 2020-08-26 8:17 ` [PATCH 3/5] over: recent: remove expensive COUNT query Eric Wong 2020-08-26 8:17 ` Eric Wong [this message] 2020-08-26 8:17 ` [PATCH 5/5] msgmap: use v5.10.1 Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200826081742.16642-5-e@yhbt.net \ --to=e@yhbt.net \ --cc=meta@public-inbox.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
user/dev discussion of public-inbox itself This inbox may be cloned and mirrored by anyone: git clone --mirror http://public-inbox.org/meta git clone --mirror http://czquwvybam4bgbro.onion/meta git clone --mirror http://hjrcffqmbrq6wope.onion/meta git clone --mirror http://ou63pmih66umazou.onion/meta # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 meta meta/ http://public-inbox.org/meta \ meta@public-inbox.org public-inbox-index meta Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta nntp://news.gmane.io/gmane.mail.public-inbox.general note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/public-inbox.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git