From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 4/5] over*: use v5.10.1, drop warnings
Date: Wed, 26 Aug 2020 08:17:41 +0000 [thread overview]
Message-ID: <20200826081742.16642-5-e@yhbt.net> (raw)
In-Reply-To: <20200826081742.16642-1-e@yhbt.net>
v5.10.1 lets us use the lighter parent.pm instead of base.pm,
and we'll rely on the shebang to enable warnings (or not).
While we're in the area, drop a no-longer-necessary import for
PublicInbox::Search, since OverIdx doesn't require search.
---
lib/PublicInbox/Over.pm | 2 +-
lib/PublicInbox/OverIdx.pm | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index 6b7d5216..0957cbdd 100644
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -6,7 +6,7 @@
# tweaked/updated over time and rebuilt.
package PublicInbox::Over;
use strict;
-use warnings;
+use v5.10.1;
use DBI;
use DBD::SQLite;
use PublicInbox::Smsg;
diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index 512c5f46..67f8cf65 100644
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -9,14 +9,13 @@
# are denoted by a negative NNTP article number.
package PublicInbox::OverIdx;
use strict;
-use warnings;
-use base qw(PublicInbox::Over);
+use v5.10.1;
+use parent qw(PublicInbox::Over);
use IO::Handle;
use DBI qw(:sql_types); # SQL_BLOB
use PublicInbox::MID qw/id_compress mids_for_index references/;
use PublicInbox::Smsg qw(subject_normalized);
use Compress::Zlib qw(compress);
-use PublicInbox::Search;
use Carp qw(croak);
sub dbh_new {
next prev parent reply other threads:[~2020-08-26 8:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 8:17 [PATCH 0/5] some minor SQLite-related cleanups Eric Wong
2020-08-26 8:17 ` [PATCH 1/5] over: rename ->connect method to ->dbh Eric Wong
2020-08-26 8:17 ` [PATCH 2/5] over: rename ->disconnect to ->dbh_close Eric Wong
2020-08-26 8:17 ` [PATCH 3/5] over: recent: remove expensive COUNT query Eric Wong
2020-08-26 8:17 ` Eric Wong [this message]
2020-08-26 8:17 ` [PATCH 5/5] msgmap: use v5.10.1 Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826081742.16642-5-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).