From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH] index: --compact respects --jobs.
Date: Sun, 26 Jul 2020 09:31:10 +0000 [thread overview]
Message-ID: <20200726093110.22773-1-e@yhbt.net> (raw)
And -compact supports --jobs=0 like -index to disable parallel
execution. Running three xapian-compact processes in parallel
on a USB 2.0 HDD is pretty painful.
---
lib/PublicInbox/Xapcmd.pm | 2 +-
script/public-inbox-index | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Xapcmd.pm b/lib/PublicInbox/Xapcmd.pm
index d6c069d75..3b7a581bd 100644
--- a/lib/PublicInbox/Xapcmd.pm
+++ b/lib/PublicInbox/Xapcmd.pm
@@ -129,7 +129,7 @@ sub same_fs_or_die ($$) {
sub process_queue {
my ($queue, $cb, $opt) = @_;
- my $max = $opt->{jobs} || scalar(@$queue);
+ my $max = $opt->{jobs} // scalar(@$queue);
if ($max <= 1) {
while (defined(my $args = shift @$queue)) {
$cb->($args, $opt);
diff --git a/script/public-inbox-index b/script/public-inbox-index
index d5c7cae2b..5a0ceab78 100755
--- a/script/public-inbox-index
+++ b/script/public-inbox-index
@@ -24,6 +24,9 @@ if ($opt->{compact}) {
require PublicInbox::Xapcmd;
PublicInbox::Xapcmd::check_compact();
$compact_opt = { -coarse_lock => 1, compact => 1 };
+ if (defined(my $jobs = $opt->{jobs})) {
+ $compact_opt->{jobs} = $jobs;
+ }
}
my $cfg = PublicInbox::Config->new;
reply other threads:[~2020-07-26 9:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726093110.22773-1-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).