From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 8F9051F5AF for ; Fri, 17 Jul 2020 06:31:55 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/8] v2: use v5.10.1, parent.pm, drop warnings Date: Fri, 17 Jul 2020 06:31:48 +0000 Message-Id: <20200717063155.3734-2-e@yhbt.net> In-Reply-To: <20200717063155.3734-1-e@yhbt.net> References: <20200717063155.3734-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: The "5.010_001" form was for Perl 5.6, which I doubt anybody would attempt; so favor "v5.10.1" as it is more readable to humans. Prefer "parent" to "base" since the former is lighter. We'll also rely on warnings from "-w" globally (or not) instead of via "use". We'll also update "use" statements to reflect what's actually used by V2Writable. --- lib/PublicInbox/SearchIdxShard.pm | 4 ++-- lib/PublicInbox/V2Writable.pm | 7 +++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm index f7ba293f..baf7352a 100644 --- a/lib/PublicInbox/SearchIdxShard.pm +++ b/lib/PublicInbox/SearchIdxShard.pm @@ -5,8 +5,8 @@ # See L for more info on how we shard Xapian package PublicInbox::SearchIdxShard; use strict; -use warnings; -use base qw(PublicInbox::SearchIdx); +use v5.10.1; +use parent qw(PublicInbox::SearchIdx); use IO::Handle (); # autoflush use PublicInbox::Eml; diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index 528f5e9a..0119ea76 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -5,16 +5,15 @@ # Used to write to V2 inboxes (see L). package PublicInbox::V2Writable; use strict; -use warnings; -use base qw(PublicInbox::Lock); -use 5.010_001; +use v5.10.1; +use parent qw(PublicInbox::Lock); use PublicInbox::SearchIdxShard; use PublicInbox::Eml; use PublicInbox::Git; use PublicInbox::Import; use PublicInbox::MID qw(mids references); use PublicInbox::ContentHash qw(content_hash content_digest); -use PublicInbox::Inbox; +use PublicInbox::InboxWritable; use PublicInbox::OverIdx; use PublicInbox::Msgmap; use PublicInbox::Spawn qw(spawn popen_rd);