From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2DA7F1F5AF for ; Tue, 14 Jul 2020 02:14:33 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/3] over: unset sqlite_unicode attribute Date: Tue, 14 Jul 2020 02:14:30 +0000 Message-Id: <20200714021432.11024-2-e@yhbt.net> In-Reply-To: <20200714021432.11024-1-e@yhbt.net> References: <20200714021432.11024-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: None of the human-readable strings stored in over.sqlite3 require UTF-8. Message-IDs do not, nor do the compressed Subject IDs (sid) we use for Subject-based threading. And the `ddd' (doc-data-deflated) column is of course binary data. This frees us of having to use SQL_BLOB for the `ddd', column, and will open the door for us to use dbh_new for Msgmap, too. --- lib/PublicInbox/Over.pm | 1 - lib/PublicInbox/OverIdx.pm | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm index e5a980d5..5d285057 100644 --- a/lib/PublicInbox/Over.pm +++ b/lib/PublicInbox/Over.pm @@ -36,7 +36,6 @@ sub dbh_new { $st = pack('dd', $st[0], $st[1]); } while ($st ne $self->{st} && $tries++ < 3); warn "W: $f: .st_dev, .st_ino unstable\n" if $st ne $self->{st}; - $dbh->{sqlite_unicode} = 1; $dbh; } diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm index 008a5d1a..13aa2d74 100644 --- a/lib/PublicInbox/OverIdx.pm +++ b/lib/PublicInbox/OverIdx.pm @@ -12,7 +12,7 @@ use strict; use warnings; use base qw(PublicInbox::Over); use IO::Handle; -use DBI qw(:sql_types); # SQL_BLOB +use DBI; use PublicInbox::MID qw/id_compress mids_for_index references/; use PublicInbox::Smsg qw(subject_normalized); use Compress::Zlib qw(compress); @@ -309,7 +309,7 @@ VALUES (?,?,?,?,?,?) my $n = 0; my @v = ($num, $tid, $sid, $ts, $ds); foreach (@v) { $sth->bind_param(++$n, $_) } - $sth->bind_param(++$n, $ddd, SQL_BLOB); + $sth->bind_param(++$n, $ddd); $sth->execute; $sth = $dbh->prepare_cached(<<''); INSERT INTO id2num (id, num) VALUES (?,?)