* [PATCH] inboxidle: warn on inotify_add_watch failures
@ 2020-07-06 4:20 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-07-06 4:20 UTC (permalink / raw)
To: meta
inotify_add_watch(2), open(2), stat(2) may all fail due to
permissions errors, especially when running -nntpd/-imapd
as `nobody' as recommended.
---
lib/PublicInbox/InboxIdle.pm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/InboxIdle.pm b/lib/PublicInbox/InboxIdle.pm
index bdb30284a..0cdd2e2a8 100644
--- a/lib/PublicInbox/InboxIdle.pm
+++ b/lib/PublicInbox/InboxIdle.pm
@@ -41,8 +41,11 @@ sub in2_arm ($$) { # PublicInbox::Config::each_inbox callback
$cur->[0] = $ibx;
my $lock = "$dir/".($ibx->version >= 2 ? 'inbox.lock' : 'ssoma.lock');
- my $w = $cur->[1] = $inot->watch($lock, $IN_MODIFY);
- $self->{on_unlock}->{$w->name} = $ibx;
+ if (my $w = $cur->[1] = $inot->watch($lock, $IN_MODIFY)) {
+ $self->{on_unlock}->{$w->name} = $ibx;
+ } else {
+ warn "E: ".ref($inot)."->watch($lock, IN_MODIFY) failed: $!\n";
+ }
# TODO: detect deleted packs (and possibly other files)
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-06 4:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 4:20 [PATCH] inboxidle: warn on inotify_add_watch failures Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).