user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] inboxidle: warn on inotify_add_watch failures
@ 2020-07-06  4:20 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-07-06  4:20 UTC (permalink / raw)
  To: meta

inotify_add_watch(2), open(2), stat(2) may all fail due to
permissions errors, especially when running -nntpd/-imapd
as `nobody' as recommended.
---
 lib/PublicInbox/InboxIdle.pm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/InboxIdle.pm b/lib/PublicInbox/InboxIdle.pm
index bdb30284a..0cdd2e2a8 100644
--- a/lib/PublicInbox/InboxIdle.pm
+++ b/lib/PublicInbox/InboxIdle.pm
@@ -41,8 +41,11 @@ sub in2_arm ($$) { # PublicInbox::Config::each_inbox callback
 	$cur->[0] = $ibx;
 
 	my $lock = "$dir/".($ibx->version >= 2 ? 'inbox.lock' : 'ssoma.lock');
-	my $w = $cur->[1] = $inot->watch($lock, $IN_MODIFY);
-	$self->{on_unlock}->{$w->name} = $ibx;
+	if (my $w = $cur->[1] = $inot->watch($lock, $IN_MODIFY)) {
+		$self->{on_unlock}->{$w->name} = $ibx;
+	} else {
+		warn "E: ".ref($inot)."->watch($lock, IN_MODIFY) failed: $!\n";
+	}
 
 	# TODO: detect deleted packs (and possibly other files)
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06  4:20 [PATCH] inboxidle: warn on inotify_add_watch failures Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git