From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 506311F94B for ; Sun, 5 Jul 2020 23:28:14 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 33/43] ssearchview: /$INBOX/?q=$QUERY&x=t uses async blobs Date: Sun, 5 Jul 2020 23:27:49 +0000 Message-Id: <20200705232759.3161-34-e@yhbt.net> In-Reply-To: <20200705232759.3161-1-e@yhbt.net> References: <20200705232759.3161-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Another 10% or so speedup when displaying full messages off search results. --- lib/PublicInbox/SearchView.pm | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm index eeebdfa31..921992a5d 100644 --- a/lib/PublicInbox/SearchView.pm +++ b/lib/PublicInbox/SearchView.pm @@ -287,21 +287,18 @@ sub mset_thread { @$msgs = reverse @$msgs if $r; $ctx->{msgs} = $msgs; - PublicInbox::WwwStream::response($ctx, 200, \&mset_thread_i); + PublicInbox::WwwStream::aresponse($ctx, 200, \&mset_thread_i); } # callback for PublicInbox::WwwStream::getline sub mset_thread_i { - my ($ctx) = @_; - return $ctx->html_top if exists $ctx->{-html_tip}; - my $msgs = $ctx->{msgs} or return; - while (my $smsg = pop @$msgs) { - my $eml = $ctx->{-inbox}->smsg_eml($smsg) or next; - return PublicInbox::View::eml_entry($ctx, $smsg, $eml, - scalar @$msgs); - } - my ($skel) = delete @$ctx{qw(skel msgs)}; - $$skel .= "\n"; + my ($ctx, $eml) = @_; + $ctx->zmore($ctx->html_top) if exists $ctx->{-html_tip}; + $eml and return PublicInbox::View::eml_entry($ctx, $ctx->{smsg}, $eml, + scalar @{$ctx->{msgs}}); + my $smsg = shift @{$ctx->{msgs}} or + $ctx->zmore(${delete($ctx->{skel})}); + $smsg; } sub ctx_prepare {