From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B68A41F939 for ; Sun, 5 Jul 2020 23:28:13 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 31/43] feed: generate_i: eliminate pointless loop Date: Sun, 5 Jul 2020 23:27:47 +0000 Message-Id: <20200705232759.3161-32-e@yhbt.net> In-Reply-To: <20200705232759.3161-1-e@yhbt.net> References: <20200705232759.3161-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: $ctx->{msgs} won't ever contain undef values. --- lib/PublicInbox/Feed.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm index b15fc3a09..9141faaf0 100644 --- a/lib/PublicInbox/Feed.pm +++ b/lib/PublicInbox/Feed.pm @@ -11,9 +11,7 @@ use PublicInbox::Smsg; # this loads w/o Search::Xapian sub generate_i { my ($ctx) = @_; - while (my $smsg = shift @{$ctx->{msgs}}) { - return $smsg; - } + shift @{$ctx->{msgs}}; } # main function