From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A41501F5AE for ; Mon, 29 Jun 2020 00:30:52 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] t/run: show unexpected output lines in logs Date: Mon, 29 Jun 2020 00:30:52 +0000 Message-Id: <20200629003052.3123-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This will help us catch warnings in new code and notice inadvertantly skipped tests. --- t/run.perl | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/t/run.perl b/t/run.perl index 017ca3e82c7..b1a0d2fe154 100755 --- a/t/run.perl +++ b/t/run.perl @@ -61,7 +61,19 @@ our ($worker, $worker_test); sub test_status () { $? = 255 if $? == 0 && !$tb->is_passing; my $status = $? ? 'not ok' : 'ok'; - print OLDOUT "$status $worker_test\n" if $log_suffix ne ''; + chdir($cwd) or DIE "chdir($cwd): $!"; + if ($log_suffix ne '') { + my $log = $worker_test; + $log =~ s/\.t\z/$log_suffix/; + if (open my $fh, '<', $log) { + my @not_ok = grep(!/^(?:ok |[ \t]*#)/ms, <$fh>); + pop @not_ok if $not_ok[-1] =~ /^[0-9]+\.\.[0-9]+$/; + print OLDERR map { "# $log: $_" } @not_ok; + } else { + print OLDERR "could not open: $log: $!\n"; + } + print OLDOUT "$status $worker_test\n"; + } } # Test::Builder or Test2::Hub may call exit() from plan(skip_all => ...) @@ -112,7 +124,6 @@ my $start_worker = sub { my $t = unpack('I', $buf); run_test($todo->[$t]); $tb->reset; - chdir($cwd) or DIE "chdir: $!"; } kill 'USR1', $producer if !$eof; # sets $eof in $producer DIE join('', map { "E: $_\n" } @err) if @err;