user/dev discussion of public-inbox itself
 help / color / Atom feed
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH] t/run: show unexpected output lines in logs
Date: Mon, 29 Jun 2020 00:30:52 +0000
Message-ID: <20200629003052.3123-1-e@yhbt.net> (raw)

This will help us catch warnings in new code and notice
inadvertantly skipped tests.
---
 t/run.perl | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/t/run.perl b/t/run.perl
index 017ca3e82c7..b1a0d2fe154 100755
--- a/t/run.perl
+++ b/t/run.perl
@@ -61,7 +61,19 @@ our ($worker, $worker_test);
 sub test_status () {
 	$? = 255 if $? == 0 && !$tb->is_passing;
 	my $status = $? ? 'not ok' : 'ok';
-	print OLDOUT "$status $worker_test\n" if $log_suffix ne '';
+	chdir($cwd) or DIE "chdir($cwd): $!";
+	if ($log_suffix ne '') {
+		my $log = $worker_test;
+		$log =~ s/\.t\z/$log_suffix/;
+		if (open my $fh, '<', $log) {
+			my @not_ok = grep(!/^(?:ok |[ \t]*#)/ms, <$fh>);
+			pop @not_ok if $not_ok[-1] =~ /^[0-9]+\.\.[0-9]+$/;
+			print OLDERR map { "# $log: $_" } @not_ok;
+		} else {
+			print OLDERR "could not open: $log: $!\n";
+		}
+		print OLDOUT "$status $worker_test\n";
+	}
 }
 
 # Test::Builder or Test2::Hub may call exit() from plan(skip_all => ...)
@@ -112,7 +124,6 @@ my $start_worker = sub {
 			my $t = unpack('I', $buf);
 			run_test($todo->[$t]);
 			$tb->reset;
-			chdir($cwd) or DIE "chdir: $!";
 		}
 		kill 'USR1', $producer if !$eof; # sets $eof in $producer
 		DIE join('', map { "E: $_\n" } @err) if @err;

                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629003052.3123-1-e@yhbt.net \
    --to=e@yhbt.net \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git