user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 2/2] imap: refill_xap: remove needless loop
Date: Sun, 21 Jun 2020 19:23:25 +0000	[thread overview]
Message-ID: <20200621192325.18165-3-e@yhbt.net> (raw)
In-Reply-To: <20200621192325.18165-1-e@yhbt.net>

There's no need to loop when the first iteration guarantees
a `return'.
---
 lib/PublicInbox/IMAP.pm | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index 0508ae381dd..941ce3af495 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -1172,16 +1172,13 @@ sub refill_xap ($$$$) {
 	my $srch = $self->{ibx}->search;
 	my $opt = { mset => 2, limit => 1000 };
 	my $nshard = $srch->{nshard} // 1;
-	while (1) {
-		my $mset = $srch->query("$q uid:$beg..$end", $opt);
-		@$uids = map { mdocid($nshard, $_) } $mset->items;
-		if (@$uids) {
-			$range_info->[0] = $uids->[-1] + 1; # update $beg
-			return;
-		} else { # all done
-			return 0;
-		}
+	my $mset = $srch->query("$q uid:$beg..$end", $opt);
+	@$uids = map { mdocid($nshard, $_) } $mset->items;
+	if (@$uids) {
+		$range_info->[0] = $uids->[-1] + 1; # update $beg
+		return; # possibly more
 	}
+	0; # all done
 }
 
 sub search_xap_range { # long_response

      parent reply	other threads:[~2020-06-21 19:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-21 19:23 [PATCH 0/2] imap: search fixes Eric Wong
2020-06-21 19:23 ` [PATCH 1/2] imap: *SEARCH: return no results for out-of-range queries Eric Wong
2020-06-22 19:07   ` [REJECT] " Eric Wong
2020-06-21 19:23 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200621192325.18165-3-e@yhbt.net \
    --to=e@yhbt.net \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).