* [PATCH] spamcheck/spamc: use localized slurp to read from spamc
@ 2020-05-19 22:45 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-05-19 22:45 UTC (permalink / raw)
To: meta
The <EXPR> perlop, `readline', and `read' functions will all
retry on EINTR, so there's no need to retry and loop ourselves
with `sysread'.
---
lib/PublicInbox/Spamcheck/Spamc.pm | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/lib/PublicInbox/Spamcheck/Spamc.pm b/lib/PublicInbox/Spamcheck/Spamc.pm
index b6098669..3ba2c3c9 100644
--- a/lib/PublicInbox/Spamcheck/Spamc.pm
+++ b/lib/PublicInbox/Spamcheck/Spamc.pm
@@ -23,19 +23,11 @@ sub spamcheck {
my $rdr = { 0 => _msg_to_fh($self, $msg) };
my ($fh, $pid) = popen_rd($self->{checkcmd}, undef, $rdr);
- my $r;
unless (ref $out) {
my $buf = '';
$out = \$buf;
}
-again:
- do {
- $r = sysread($fh, $$out, 65536, length($$out));
- } while (defined($r) && $r != 0);
- unless (defined $r) {
- goto again if $!{EINTR};
- die "read failed: $!";
- }
+ $$out = do { local $/; <$fh> };
close $fh or die "close failed: $!";
waitpid($pid, 0);
($? || $$out eq '') ? 0 : 1;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-05-19 22:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 22:45 [PATCH] spamcheck/spamc: use localized slurp to read from spamc Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).