From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D7D921F55B; Sat, 16 May 2020 07:42:38 +0000 (UTC) Date: Sat, 16 May 2020 07:42:37 +0000 From: Eric Wong To: "Eric W. Biederman" Cc: meta@public-inbox.org Subject: Re: [PATCH] PublicInbox::Inbox.pm: Default unset address to a one element array Message-ID: <20200516074237.GA51736@dcvr> References: <871rnkc38s.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <871rnkc38s.fsf@x220.int.ebiederm.org> List-Id: "Eric W. Biederman" wrote: > > PublicInbox::Config.pm::_fill() assumes that address is an array. > Therefore when handling an unset address use an array containing a > single string, instead of a single string. > > Signed-off-by: "Eric W. Biederman" Thanks, pushed as 0a556c99c0db5160f43931422a563c6094b64ea2 > I accidentially created a public inbox without an address at some > point and had some nasty errors because the default value > we game to address is not an array. Yeah, I've been thinking about making it more suitable for personal mail, and the address field requirement is a bit annoying. Though I suppose it could be useful for making search queries easier by expanding queries, using "$self" as a placeholder to expand to all defined addresses for folks with multiple email addresses... but maybe .mailmap is better for that.