user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] PublicInbox::Inbox.pm: Default unset address to a one element array
@ 2020-05-15 21:11 Eric W. Biederman
  2020-05-16  7:42 ` Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Eric W. Biederman @ 2020-05-15 21:11 UTC (permalink / raw)
  To: Eric Wong; +Cc: meta


PublicInbox::Config.pm::_fill() assumes that address is an array.
Therefore when handling an unset address use an array containing a
single string, instead of a single string.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---

I accidentially created a public inbox without an address at some
point and had some nasty errors because the default value
we game to address is not an array.

 lib/PublicInbox/Inbox.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 617b692b14ca..002b980f4057 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -102,7 +102,7 @@ sub _set_limiter ($$$) {
 
 sub new {
 	my ($class, $opts) = @_;
-	my $v = $opts->{address} ||= 'public-inbox@example.com';
+	my $v = $opts->{address} ||= [ 'public-inbox@example.com' ];
 	my $p = $opts->{-primary_address} = ref($v) eq 'ARRAY' ? $v->[0] : $v;
 	$opts->{domain} = ($p =~ /\@(\S+)\z/) ? $1 : 'localhost';
 	my $pi_config = delete $opts->{-pi_config};
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] PublicInbox::Inbox.pm: Default unset address to a one element array
  2020-05-15 21:11 [PATCH] PublicInbox::Inbox.pm: Default unset address to a one element array Eric W. Biederman
@ 2020-05-16  7:42 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2020-05-16  7:42 UTC (permalink / raw)
  To: Eric W. Biederman; +Cc: meta

"Eric W. Biederman" <ebiederm@xmission.com> wrote:
> 
> PublicInbox::Config.pm::_fill() assumes that address is an array.
> Therefore when handling an unset address use an array containing a
> single string, instead of a single string.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

Thanks, pushed as 0a556c99c0db5160f43931422a563c6094b64ea2

> I accidentially created a public inbox without an address at some
> point and had some nasty errors because the default value
> we game to address is not an array.

Yeah, I've been thinking about making it more suitable for
personal mail, and the address field requirement is a bit
annoying.

Though I suppose it could be useful for making search queries
easier by expanding queries, using "$self" as a placeholder
to expand to all defined addresses for folks with multiple
email addresses... but maybe .mailmap is better for that.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15 21:11 [PATCH] PublicInbox::Inbox.pm: Default unset address to a one element array Eric W. Biederman
2020-05-16  7:42 ` Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git