user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@yhbt.net>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] PublicInbox::Inbox.pm: Default unset address to a one element array
Date: Sat, 16 May 2020 07:42:37 +0000	[thread overview]
Message-ID: <20200516074237.GA51736@dcvr> (raw)
In-Reply-To: <871rnkc38s.fsf@x220.int.ebiederm.org>

"Eric W. Biederman" <ebiederm@xmission.com> wrote:
> 
> PublicInbox::Config.pm::_fill() assumes that address is an array.
> Therefore when handling an unset address use an array containing a
> single string, instead of a single string.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

Thanks, pushed as 0a556c99c0db5160f43931422a563c6094b64ea2

> I accidentially created a public inbox without an address at some
> point and had some nasty errors because the default value
> we game to address is not an array.

Yeah, I've been thinking about making it more suitable for
personal mail, and the address field requirement is a bit
annoying.

Though I suppose it could be useful for making search queries
easier by expanding queries, using "$self" as a placeholder
to expand to all defined addresses for folks with multiple
email addresses... but maybe .mailmap is better for that.

      reply	other threads:[~2020-05-16  7:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 21:11 [PATCH] PublicInbox::Inbox.pm: Default unset address to a one element array Eric W. Biederman
2020-05-16  7:42 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200516074237.GA51736@dcvr \
    --to=e@yhbt.net \
    --cc=ebiederm@xmission.com \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).