From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id AFDAD1F55B for ; Sun, 10 May 2020 19:38:23 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] build: check-manifest runs after tests Date: Sun, 10 May 2020 19:38:23 +0000 Message-Id: <20200510193823.29827-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: And just treat it as a non-fatal nag when checking the rest of the codebase. Calling it "check-manifest" as a `make' target preserves the old behavior, which causes the check to fail if a file were added to the worktree without changing the MANIFEST. --- Makefile.PL | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 30b8adda2f0..472baa9b080 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -180,18 +180,22 @@ syntax:: \$(my_syntax) changed = \$(shell git ls-files -m) dsyn :: \$(addsuffix .syntax, \$(filter \$(changed), \$(syn_files))) -check-manifest :: MANIFEST - if test -e .git && git ls-files >\$?.gen 2>&1; then \\ - diff -u \$? \$?.gen; fi +check_manifest := if test -e .git && git ls-files >MANIFEST.gen 2>&1; then \\ + diff -u MANIFEST MANIFEST.gen; fi + +check-manifest : MANIFEST + \$(check_manifest) # the traditional way running per-*.t processes: -check-each :: pure_all check-manifest +check-each :: pure_all \$(EATMYDATA) \$(PROVE) --state=save -bvw -j\$(N) + -@\$(check_manifest) # lightly-tested way to run tests, relies "--state=save" in check-each # for best performance -check-run :: pure_all check-manifest +check-run :: pure_all \$(EATMYDATA) \$(PROVE) -bvw t/run.perl :: -j\$(N) + -@\$(check_manifest) check :: check-each