From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH] build: check-manifest runs after tests
Date: Sun, 10 May 2020 19:38:23 +0000 [thread overview]
Message-ID: <20200510193823.29827-1-e@yhbt.net> (raw)
And just treat it as a non-fatal nag when checking the rest of the
codebase. Calling it "check-manifest" as a `make' target
preserves the old behavior, which causes the check to fail
if a file were added to the worktree without changing the
MANIFEST.
---
Makefile.PL | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/Makefile.PL b/Makefile.PL
index 30b8adda2f0..472baa9b080 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -180,18 +180,22 @@ syntax:: \$(my_syntax)
changed = \$(shell git ls-files -m)
dsyn :: \$(addsuffix .syntax, \$(filter \$(changed), \$(syn_files)))
-check-manifest :: MANIFEST
- if test -e .git && git ls-files >\$?.gen 2>&1; then \\
- diff -u \$? \$?.gen; fi
+check_manifest := if test -e .git && git ls-files >MANIFEST.gen 2>&1; then \\
+ diff -u MANIFEST MANIFEST.gen; fi
+
+check-manifest : MANIFEST
+ \$(check_manifest)
# the traditional way running per-*.t processes:
-check-each :: pure_all check-manifest
+check-each :: pure_all
\$(EATMYDATA) \$(PROVE) --state=save -bvw -j\$(N)
+ -@\$(check_manifest)
# lightly-tested way to run tests, relies "--state=save" in check-each
# for best performance
-check-run :: pure_all check-manifest
+check-run :: pure_all
\$(EATMYDATA) \$(PROVE) -bvw t/run.perl :: -j\$(N)
+ -@\$(check_manifest)
check :: check-each
reply other threads:[~2020-05-10 19:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510193823.29827-1-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).