From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C9F751F8C4 for ; Sat, 9 May 2020 08:27:38 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/3] emlcontentfoo: quiet warning on missing attributes Date: Sat, 9 May 2020 08:27:38 +0000 Message-Id: <20200509082738.23602-4-e@yhbt.net> In-Reply-To: <20200509082738.23602-1-e@yhbt.net> References: <20200509082738.23602-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This bug was also present in Email::MIME::ContentType: commit ae081fb576d8507efca4928116ad81efa756c723 (refs/pull/pull/9/head) in https://github.com/rjbs/Email-MIME-ContentType.git Our fix is shorter, but dependent on 5.10+ as our codebase relies on Perl 5.10 features, anyways. --- lib/PublicInbox/EmlContentFoo.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/EmlContentFoo.pm b/lib/PublicInbox/EmlContentFoo.pm index 7472f8d2..e6005d29 100644 --- a/lib/PublicInbox/EmlContentFoo.pm +++ b/lib/PublicInbox/EmlContentFoo.pm @@ -190,7 +190,7 @@ sub _process_rfc2231 { foreach (keys %{$attribs}) { next unless $_ =~ m/^(.*)\*$/; my $key = $1; - next unless $attribs->{$_} =~ m/^$re_exvalue$/; + next unless ($attribs->{$_} // '') =~ m/^$re_exvalue$/; my ($charset, $value) = ($1, $2); $value =~ s/%([0-9A-Fa-f]{2})/pack('C', hex($1))/eg; if (length $charset) {