From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B8A711F8C1; Fri, 8 May 2020 04:47:33 +0000 (UTC) Date: Fri, 8 May 2020 04:47:33 +0000 From: Eric Wong To: meta@public-inbox.org Subject: Re: [PATCH 11/13] xt: eml comparison tests Message-ID: <20200508044733.GA14379@dcvr> References: <20200507210556.22995-1-e@yhbt.net> <20200507210556.22995-12-e@yhbt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200507210556.22995-12-e@yhbt.net> List-Id: Eric Wong wrote: > xt/cmp-msgstr.t | 108 +++++++++++++++++++++++++++++++++++++++++++++++ > xt/cmp-msgview.t | 95 +++++++++++++++++++++++++++++++++++++++++ Btw, I run these in parallel on inboxes I have: N=$(nproc) find ~/v2/*/git/ -type d -name '*.git' -print0 | xargs -0 -P$N -n1 sh -c \ 'GIANT_INBOX_DIR=$1 perl -I lib -w xt/cmp-msgview.t' -- find ~/v1/ -type d -name '*.git' -print0 | xargs -0 -P$N -n1 sh -c \ 'GIANT_INBOX_DIR=$1 perl -I lib -w xt/cmp-msgstr.t' -- And the main differences I see are minor: * trailing whitespace may still be different for broken messages missing epilogues (MIMEDefang, or some old gnus + GPG) * trailing whitespace differences for header extraction (Eml strips all trailing spaces, not just LF/CRLF) * empty parts of multipart messages are skipped for efficiency