From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 1/2] t/httpd-corner.t: fix uninitialized warning
Date: Fri, 1 May 2020 18:04:44 +0000 [thread overview]
Message-ID: <20200501180445.16513-2-e@yhbt.net> (raw)
In-Reply-To: <20200501180445.16513-1-e@yhbt.net>
Current versions of Perl don't warn when vec() is given `undef'
as its first arg, but Perl 5.10.1 does, at least.
Fixes: c7b4cbdadf3116a0 ("t/httpd-corner: improve reliability and diagnostics")
---
t/httpd-corner.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/httpd-corner.t b/t/httpd-corner.t
index 7a6bcc66..68148655 100644
--- a/t/httpd-corner.t
+++ b/t/httpd-corner.t
@@ -296,7 +296,7 @@ my $len = length $str;
is($len, 26, 'got the alphabet');
my $check_self = sub {
my ($conn) = @_;
- vec(my $rbits, fileno($conn), 1) = 1;
+ vec(my $rbits = '', fileno($conn), 1) = 1;
select($rbits, undef, undef, 30) or Carp::confess('timed out');
$conn->read(my $buf, 4096);
my ($head, $body) = split(/\r\n\r\n/, $buf, 2);
next prev parent reply other threads:[~2020-05-01 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 18:04 [PATCH 0/2] tests: Perl 5.10.1 fixes Eric Wong
2020-05-01 18:04 ` Eric Wong [this message]
2020-05-01 18:04 ` [PATCH 2/2] t/convert-compact: avoid warning on `scalar(split(...))' Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501180445.16513-2-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).